[GitHub] [tvm] mbs-octoml commented on a change in pull request #9501: [3/3][AOT][DeviceAPI] Wire up cpacked Device API context

[GitBox <gi...@apache.org>]

mbs-octoml commented on a change in pull request #9501:
URL: https://github.com/apache/tvm/pull/9501#discussion_r750492272



##########
File path: src/relay/backend/aot_executor_codegen.cc
##########
@@ -347,18 +347,30 @@ class AOTExecutorCodegen : public MixedModeVisitor {
     }
 
     GlobalVar global_var = call_lowered_props.lowered_func;
+    tir::Var empty_var("no_device_context", DataType::Handle());
     bool has_c_device_api_context = device_contexts_.count(global_var) != 0;
+    bool use_cpacked_api = !use_unpacked_api_;
+
     if (has_c_device_api_context) {

Review comment:
       Let's comment these three semi-implicit calling conventions here, including a one-sentence summary of where the extra args show up in the runtime.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org