[GitHub] [skywalking-banyandb-java-client] lujiajing1126 commented on pull request #7: Add measure API for Java Client

[GitBox <gi...@apache.org>]

lujiajing1126 commented on pull request #7:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/7#issuecomment-1086819932


   > Things about gRPC connection relative things are missing.
   > 
   > 1. `channel` could be required to re-establish due to you set the remote address as a DNS name, and it is managed on k8s, then IP or route could be changed. Java agent's `GRPCChannelManager` is a refference.
   > 2. `channel` should consider TLS/mTLS
   > 3. `AbstractBulkWriteProcessor`'s bulk mechanism misses the waiting mechanism for server side. The client would be very easy to OOM(out of stack memory due to netty) if you push too much data in bulk.
   > 4. `write(StreamWrite streamWrite)` doesn't have deadline setting.
   > 5. `BanyanDBClient#Options` docs are missing.
   
   1,2,4,5 are implemented.
   
   > 3. `AbstractBulkWriteProcessor`'s bulk mechanism misses the waiting mechanism for server side. The client would be very easy to OOM(out of stack memory due to netty) if you push too much data in bulk.
   
   Still investigating this problem... Any idea?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org