You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2005/01/27 00:30:19 UTC

[jira] Created: (MAVEN-1556) Inconsistent use of repositoryConnection and repositoryDeveloperConnectio

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MAVEN-1556

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MAVEN-1556
    Summary: Inconsistent use of repositoryConnection and repositoryDeveloperConnectio
       Type: Bug

     Status: Unassigned
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven
   Versions:
             1.0.2

   Assignee: 
   Reporter: Martin West

    Created: Wed, 26 Jan 2005 6:29 PM
    Updated: Wed, 26 Jan 2005 6:29 PM
Environment: All

Description:
The scm plugin uses developerConnection and the repositoryConnection but the report plugins like changelog, file-activity, developer-activity perform the test the other way round.

The report plugins should use the scm plugin test order ...

        <j:if test="${!empty(value)}">
          <echo>Using connection: ${pom.repository.developerConnection}</echo>
          <j:set var="conn" value="${pom.repository.developerConnection}" />
        </j:if>
      </j:if>
                                                                                                      
      <j:if test="${conn == null}">
        <j:set var="value" value="${pom.repository.connection}"/>
        <j:if test="${!empty(value)}">
          <echo>Using connection: ${pom.repository.connection}</echo>
          <j:set var="conn" value="${pom.repository.connection}" />
        </j:if>
 
Not ....

          <j:set var="_connection">${pom.repository.connection}</j:set>
        <j:if test="${empty(_connection)}">
        <j:set var="_connection">${pom.repository.developerConnection}</j:set>
        </j:if>
 


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MPCHANGELOG-62) Inconsistent use of repositoryConnection and repositoryDeveloperConnectio

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPCHANGELOG-62?page=all ]

Brett Porter updated MPCHANGELOG-62:
------------------------------------

    Fix Version: 1.8
    Description: 
The scm plugin uses developerConnection and the repositoryConnection but the report plugins like changelog, file-activity, developer-activity perform the test the other way round.

The report plugins should use the scm plugin test order ...

        <j:if test="${!empty(value)}">
          <echo>Using connection: ${pom.repository.developerConnection}</echo>
          <j:set var="conn" value="${pom.repository.developerConnection}" />
        </j:if>
      </j:if>
                                                                                                      
      <j:if test="${conn == null}">
        <j:set var="value" value="${pom.repository.connection}"/>
        <j:if test="${!empty(value)}">
          <echo>Using connection: ${pom.repository.connection}</echo>
          <j:set var="conn" value="${pom.repository.connection}" />
        </j:if>
 
Not ....

          <j:set var="_connection">${pom.repository.connection}</j:set>
        <j:if test="${empty(_connection)}">
        <j:set var="_connection">${pom.repository.developerConnection}</j:set>
        </j:if>

  was:
The scm plugin uses developerConnection and the repositoryConnection but the report plugins like changelog, file-activity, developer-activity perform the test the other way round.

The report plugins should use the scm plugin test order ...

        <j:if test="${!empty(value)}">
          <echo>Using connection: ${pom.repository.developerConnection}</echo>
          <j:set var="conn" value="${pom.repository.developerConnection}" />
        </j:if>
      </j:if>
                                                                                                      
      <j:if test="${conn == null}">
        <j:set var="value" value="${pom.repository.connection}"/>
        <j:if test="${!empty(value)}">
          <echo>Using connection: ${pom.repository.connection}</echo>
          <j:set var="conn" value="${pom.repository.connection}" />
        </j:if>
 
Not ....

          <j:set var="_connection">${pom.repository.connection}</j:set>
        <j:if test="${empty(_connection)}">
        <j:set var="_connection">${pom.repository.developerConnection}</j:set>
        </j:if>


> Inconsistent use of repositoryConnection and repositoryDeveloperConnectio
> -------------------------------------------------------------------------
>
>          Key: MPCHANGELOG-62
>          URL: http://jira.codehaus.org/browse/MPCHANGELOG-62
>      Project: maven-changelog-plugin
>         Type: Bug
>  Environment: All
>     Reporter: Martin West
>      Fix For: 1.8

>
>
> The scm plugin uses developerConnection and the repositoryConnection but the report plugins like changelog, file-activity, developer-activity perform the test the other way round.
> The report plugins should use the scm plugin test order ...
>         <j:if test="${!empty(value)}">
>           <echo>Using connection: ${pom.repository.developerConnection}</echo>
>           <j:set var="conn" value="${pom.repository.developerConnection}" />
>         </j:if>
>       </j:if>
>                                                                                                       
>       <j:if test="${conn == null}">
>         <j:set var="value" value="${pom.repository.connection}"/>
>         <j:if test="${!empty(value)}">
>           <echo>Using connection: ${pom.repository.connection}</echo>
>           <j:set var="conn" value="${pom.repository.connection}" />
>         </j:if>
>  
> Not ....
>           <j:set var="_connection">${pom.repository.connection}</j:set>
>         <j:if test="${empty(_connection)}">
>         <j:set var="_connection">${pom.repository.developerConnection}</j:set>
>         </j:if>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPCHANGELOG-62) Inconsistent use of repositoryConnection and repositoryDeveloperConnectio

Posted by "Martin West (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPCHANGELOG-62?page=comments#action_40557 ]
     
Martin West commented on MPCHANGELOG-62:
----------------------------------------

I disagree. If I have a working developer connection it should use that connection otherwise the reports will not be accurate as anonymous cvs is often 24 hours behind the developer cvs and sometimes it disappears altogether. The reports should use the best possible connection.

> Inconsistent use of repositoryConnection and repositoryDeveloperConnectio
> -------------------------------------------------------------------------
>
>          Key: MPCHANGELOG-62
>          URL: http://jira.codehaus.org/browse/MPCHANGELOG-62
>      Project: maven-changelog-plugin
>         Type: Bug
>  Environment: All
>     Reporter: Martin West

>
>
> The scm plugin uses developerConnection and the repositoryConnection but the report plugins like changelog, file-activity, developer-activity perform the test the other way round.
> The report plugins should use the scm plugin test order ...
>         <j:if test="${!empty(value)}">
>           <echo>Using connection: ${pom.repository.developerConnection}</echo>
>           <j:set var="conn" value="${pom.repository.developerConnection}" />
>         </j:if>
>       </j:if>
>                                                                                                       
>       <j:if test="${conn == null}">
>         <j:set var="value" value="${pom.repository.connection}"/>
>         <j:if test="${!empty(value)}">
>           <echo>Using connection: ${pom.repository.connection}</echo>
>           <j:set var="conn" value="${pom.repository.connection}" />
>         </j:if>
>  
> Not ....
>           <j:set var="_connection">${pom.repository.connection}</j:set>
>         <j:if test="${empty(_connection)}">
>         <j:set var="_connection">${pom.repository.developerConnection}</j:set>
>         </j:if>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MPCHANGELOG-62) Inconsistent use of repositoryConnection and repositoryDeveloperConnectio

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPCHANGELOG-62?page=all ]
     
Brett Porter closed MPCHANGELOG-62:
-----------------------------------

    Fix Version:     (was: 1.8)
     Resolution: Won't Fix

the standard connection needs to be used, as not everyone has access to the developer connection. The standard connection is intended for read-only use, such as for the changelog plugin.

> Inconsistent use of repositoryConnection and repositoryDeveloperConnectio
> -------------------------------------------------------------------------
>
>          Key: MPCHANGELOG-62
>          URL: http://jira.codehaus.org/browse/MPCHANGELOG-62
>      Project: maven-changelog-plugin
>         Type: Bug
>  Environment: All
>     Reporter: Martin West

>
>
> The scm plugin uses developerConnection and the repositoryConnection but the report plugins like changelog, file-activity, developer-activity perform the test the other way round.
> The report plugins should use the scm plugin test order ...
>         <j:if test="${!empty(value)}">
>           <echo>Using connection: ${pom.repository.developerConnection}</echo>
>           <j:set var="conn" value="${pom.repository.developerConnection}" />
>         </j:if>
>       </j:if>
>                                                                                                       
>       <j:if test="${conn == null}">
>         <j:set var="value" value="${pom.repository.connection}"/>
>         <j:if test="${!empty(value)}">
>           <echo>Using connection: ${pom.repository.connection}</echo>
>           <j:set var="conn" value="${pom.repository.connection}" />
>         </j:if>
>  
> Not ....
>           <j:set var="_connection">${pom.repository.connection}</j:set>
>         <j:if test="${empty(_connection)}">
>         <j:set var="_connection">${pom.repository.developerConnection}</j:set>
>         </j:if>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org