You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/04/04 02:41:32 UTC

[GitHub] wu-sheng commented on issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor

wu-sheng commented on issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor
URL: https://github.com/apache/incubator-skywalking/issues/1028#issuecomment-378462180
 
 
   I think this is a bug of `xmemcached` plugin. All classes defined in `XMemcachedInstrumentation` miss the interceptor's package name. 
   
   Can you send a pull request by adding `org.apache.skywalking.apm.plugin.xmemcached.v2.` in front of our class names: https://github.com/apache/incubator-skywalking/blob/e72f668bfbe5c4d5b6ef5255d1abebb70da598ce/apm-sniffer/apm-sdk-plugin/xmemcached-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/xmemcached/v2/define/XMemcachedInstrumentation.java#L47-L51

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services