You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2013/02/07 22:41:15 UTC

git commit: added reference WICKET-5011 to javadoc and extended rawInput testing

Updated Branches:
  refs/heads/master 08af7c1a3 -> 17d71dbb6


added reference WICKET-5011 to javadoc and extended rawInput testing

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/17d71dbb
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/17d71dbb
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/17d71dbb

Branch: refs/heads/master
Commit: 17d71dbb632c453ea137d9c339093e7f0ce8aa05
Parents: 08af7c1
Author: svenmeier <sv...@apache.org>
Authored: Thu Feb 7 22:40:53 2013 +0100
Committer: svenmeier <sv...@apache.org>
Committed: Thu Feb 7 22:40:53 2013 +0100

----------------------------------------------------------------------
 .../markup/html/form/select/SelectTest.java        |   21 ++++++++++++--
 1 files changed, 18 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/17d71dbb/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/form/select/SelectTest.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/form/select/SelectTest.java b/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/form/select/SelectTest.java
index 8753a66..ff4cff0 100644
--- a/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/form/select/SelectTest.java
+++ b/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/form/select/SelectTest.java
@@ -39,16 +39,31 @@ public class SelectTest extends WicketTestCase
 
 		tester.getRequest().setParameter("select", page.option1.getValue());
 
-		page.form.onFormSubmitted();
+		tester.submitForm(page.form);
 
 		// form has error ...
-		boolean hasError = page.form.hasError();
-		assertTrue(hasError);
+		assertTrue(page.form.hasError());
 
 		// ... but option1 is selected anyway through rawInput
 		assertTrue(page.select.isSelected(page.option1));
+
+		tester.startPage(page);
+
+		// ... even after re-render
+		assertTrue(page.select.isSelected(page.option1));
+
+		tester.getRequest().setParameter("select", page.option1.getValue());
+		tester.getRequest().setParameter("text", "text is required");
+		tester.submitForm(page.form);
+
+		// ... until successful submit without rawInput
+		assertFalse(page.select.hasRawInput());
+		assertTrue(page.select.isSelected(page.option1));
 	}
 
+	/**
+	 * WICKET-5011 custom equality
+	 */
 	@Test
 	public void selectionWithouEquals()
 	{