You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2016/01/20 22:33:48 UTC
Review Request 42572: Ambari server throws error when unused configs
are present in blueprint
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/
-----------------------------------------------------------
Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
Bugs: AMBARI-14745
https://issues.apache.org/jira/browse/AMBARI-14745
Repository: ambari
Description
-------
In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java c719009
ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 8afff46
ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
Diff: https://reviews.apache.org/r/42572/diff/
Testing
-------
Unit testing is in progress.
FT: blueprints with unused config types.
Thanks,
Oliver Szabo
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/#review115821
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java (line 78)
<https://reviews.apache.org/r/42572/#comment176890>
Add some comment why this is needed
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java (line 88)
<https://reviews.apache.org/r/42572/#comment176891>
Add comment why cluster-env is skipped. Isn't there any other config type that has similar attributes as cluster-env thus should be skipped as well.
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java (line 92)
<https://reviews.apache.org/r/42572/#comment176893>
Add to the log message the reason why the config type was removed. That will help debugging.
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java (line 98)
<https://reviews.apache.org/r/42572/#comment176895>
Add to the log the reason why config type was removed from hostgroupinfo and the name of the host group
- Sebastian Toader
On Jan. 22, 2016, 11:05 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42572/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 11:05 a.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14745
> https://issues.apache.org/jira/browse/AMBARI-14745
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java c719009
> ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 8afff46
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java dd66b1b
> ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7810f92
>
> Diff: https://reviews.apache.org/r/42572/diff/
>
>
> Testing
> -------
>
> Unit testing is in progress.
> FT: blueprints with unused config types.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Laszlo Puskas <lp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/#review115820
-----------------------------------------------------------
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 22, 2016, 10:05 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42572/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 10:05 a.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14745
> https://issues.apache.org/jira/browse/AMBARI-14745
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java c719009
> ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 8afff46
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java dd66b1b
> ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7810f92
>
> Diff: https://reviews.apache.org/r/42572/diff/
>
>
> Testing
> -------
>
> Unit testing is in progress.
> FT: blueprints with unused config types.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/#review117985
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Feb. 5, 2016, 1:51 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42572/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 1:51 a.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14745
> https://issues.apache.org/jira/browse/AMBARI-14745
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 464aee7
> ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 5967a64
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java dd66b1b
> ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7810f92
>
> Diff: https://reviews.apache.org/r/42572/diff/
>
>
> Testing
> -------
>
> Unit testing is in progress.
> FT: blueprints with unused config types.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/#review117996
-----------------------------------------------------------
Ship it!
Ship It!
- Sandor Magyari
On Feb. 5, 2016, 12:51 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42572/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 12:51 a.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14745
> https://issues.apache.org/jira/browse/AMBARI-14745
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 464aee7
> ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 5967a64
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java dd66b1b
> ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7810f92
>
> Diff: https://reviews.apache.org/r/42572/diff/
>
>
> Testing
> -------
>
> Unit testing is in progress.
> FT: blueprints with unused config types.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/#review118013
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Feb. 5, 2016, 12:51 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42572/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 12:51 a.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14745
> https://issues.apache.org/jira/browse/AMBARI-14745
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 464aee7
> ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 5967a64
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java dd66b1b
> ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7810f92
>
> Diff: https://reviews.apache.org/r/42572/diff/
>
>
> Testing
> -------
>
> Unit testing is in progress.
> FT: blueprints with unused config types.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 12:51 a.m.)
Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
Changes
-------
rebase / resolve conflicts
Bugs: AMBARI-14745
https://issues.apache.org/jira/browse/AMBARI-14745
Repository: ambari
Description
-------
In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 464aee7
ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 5967a64
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java dd66b1b
ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7810f92
Diff: https://reviews.apache.org/r/42572/diff/
Testing
-------
Unit testing is in progress.
FT: blueprints with unused config types.
Thanks,
Oliver Szabo
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/#review116788
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Jan. 28, 2016, 4:46 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42572/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 4:46 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14745
> https://issues.apache.org/jira/browse/AMBARI-14745
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java c719009
> ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 8afff46
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java dd66b1b
> ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7810f92
>
> Diff: https://reviews.apache.org/r/42572/diff/
>
>
> Testing
> -------
>
> Unit testing is in progress.
> FT: blueprints with unused config types.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/
-----------------------------------------------------------
(Updated Jan. 28, 2016, 3:46 p.m.)
Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
Changes
-------
added global config
Bugs: AMBARI-14745
https://issues.apache.org/jira/browse/AMBARI-14745
Repository: ambari
Description
-------
In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java c719009
ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 8afff46
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java dd66b1b
ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7810f92
Diff: https://reviews.apache.org/r/42572/diff/
Testing
-------
Unit testing is in progress.
FT: blueprints with unused config types.
Thanks,
Oliver Szabo
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/#review115833
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Jan. 22, 2016, 12:55 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42572/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 12:55 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14745
> https://issues.apache.org/jira/browse/AMBARI-14745
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java c719009
> ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 8afff46
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java dd66b1b
> ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7810f92
>
> Diff: https://reviews.apache.org/r/42572/diff/
>
>
> Testing
> -------
>
> Unit testing is in progress.
> FT: blueprints with unused config types.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/#review115872
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Jan. 22, 2016, 11:55 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42572/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 11:55 a.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14745
> https://issues.apache.org/jira/browse/AMBARI-14745
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java c719009
> ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 8afff46
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java dd66b1b
> ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7810f92
>
> Diff: https://reviews.apache.org/r/42572/diff/
>
>
> Testing
> -------
>
> Unit testing is in progress.
> FT: blueprints with unused config types.
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 11:55 a.m.)
Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
Changes
-------
updated method name + addedd comments
Bugs: AMBARI-14745
https://issues.apache.org/jira/browse/AMBARI-14745
Repository: ambari
Description
-------
In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java c719009
ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 8afff46
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java dd66b1b
ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7810f92
Diff: https://reviews.apache.org/r/42572/diff/
Testing
-------
Unit testing is in progress.
FT: blueprints with unused config types.
Thanks,
Oliver Szabo
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 10:05 a.m.)
Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
Changes
-------
fixed failing tests
Bugs: AMBARI-14745
https://issues.apache.org/jira/browse/AMBARI-14745
Repository: ambari
Description
-------
In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java c719009
ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 8afff46
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java dd66b1b
ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7810f92
Diff: https://reviews.apache.org/r/42572/diff/
Testing
-------
Unit testing is in progress.
FT: blueprints with unused config types.
Thanks,
Oliver Szabo
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/
-----------------------------------------------------------
(Updated Jan. 21, 2016, 7:11 p.m.)
Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
Bugs: AMBARI-14745
https://issues.apache.org/jira/browse/AMBARI-14745
Repository: ambari
Description
-------
In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java c719009
ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 8afff46
ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
Diff: https://reviews.apache.org/r/42572/diff/
Testing
-------
Unit testing is in progress.
FT: blueprints with unused config types.
Thanks,
Oliver Szabo
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/
-----------------------------------------------------------
(Updated Jan. 21, 2016, 2:24 p.m.)
Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
Changes
-------
added logs
Bugs: AMBARI-14745
https://issues.apache.org/jira/browse/AMBARI-14745
Repository: ambari
Description
-------
In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java c719009
ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 8afff46
ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
Diff: https://reviews.apache.org/r/42572/diff/
Testing
-------
Unit testing is in progress.
FT: blueprints with unused config types.
Thanks,
Oliver Szabo
Re: Review Request 42572: Ambari server throws error when unused
configs are present in blueprint
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/#review115625
-----------------------------------------------------------
Ship it!
Looks fine to me. Just a minor issue below.
Thanks for creating this patch!
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java (line 85)
<https://reviews.apache.org/r/42572/#comment176611>
This looks fine to me.
Just one minor issue/request:
Could you maybe add a log statement here, to indicate that the unnecessary configuration is being removed?
The logging might be useful for users over time, to let them know that the unnecessary config types can be removed.
In addition, there are cases where services rely on other services' configuration, so if we ever ran into a situation where removing the config was a problem, the logging would simplify debugging.
Thanks.
- Robert Nettleton
On Jan. 20, 2016, 9:33 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42572/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 9:33 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14745
> https://issues.apache.org/jira/browse/AMBARI-14745
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java c719009
> ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 8afff46
> ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03
>
> Diff: https://reviews.apache.org/r/42572/diff/
>
>
> Testing
> -------
>
> Unit testing is in progress.
> FT: blueprints with unused config types.
>
>
> Thanks,
>
> Oliver Szabo
>
>