You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2021/03/08 05:36:57 UTC
[echarts] branch master updated: fix(series): fix series data type
judgment bug. close #14293 (#14413)
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts.git
The following commit(s) were added to refs/heads/master by this push:
new 13f1f03 fix(series): fix series data type judgment bug. close #14293 (#14413)
13f1f03 is described below
commit 13f1f032c6a77c8f9f4637d75fb90c655b60ee30
Author: flybird <27...@qq.com>
AuthorDate: Mon Mar 8 13:36:39 2021 +0800
fix(series): fix series data type judgment bug. close #14293 (#14413)
* fix(series): fix series data type judgment bug. close #14293
* fix(series): fix series data type judgment bug. close #14293
* fix(style): change code style
* fix(remove files): remove history files
---
src/model/Series.ts | 4 +--
test/line-non-continuous.html | 75 +++++++++++++++++++++++++++++++++++++++++++
2 files changed, 76 insertions(+), 3 deletions(-)
diff --git a/src/model/Series.ts b/src/model/Series.ts
index 7128ec3..934aa4d 100644
--- a/src/model/Series.ts
+++ b/src/model/Series.ts
@@ -575,9 +575,7 @@ class SeriesModel<Opt extends SeriesOption = SeriesOption> extends ComponentMode
if (data.hasItemOption) {
data.each(function (idx) {
const rawItem = data.getRawDataItem(idx);
- if (typeof rawItem === 'object'
- && (rawItem as OptionDataItemObject<unknown>).selected
- ) {
+ if (rawItem && (rawItem as OptionDataItemObject<unknown>).selected) {
dataIndices.push(idx);
}
});
diff --git a/test/line-non-continuous.html b/test/line-non-continuous.html
new file mode 100644
index 0000000..705aa88
--- /dev/null
+++ b/test/line-non-continuous.html
@@ -0,0 +1,75 @@
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<html>
+ <head>
+ <meta charset="utf-8">
+ <meta name="viewport" content="width=device-width, initial-scale=1" />
+ <script src="lib/esl.js"></script>
+ <script src="lib/config.js"></script>
+ <script src="lib/facePrint.js"></script>
+ </head>
+ <body>
+ <style>
+ html, body, #main {
+ width: 100%;
+ height: 100%;
+ }
+ </style>
+ <div id="info"></div>
+ (1) tick 14 and 20 should be red (has textStyle) <br>
+ (2) Check all symbol show if possible<br>
+ (3) Toggle the legend line4, the image symbol, emphasis style and normal style are normal
+ <div id="main"></div>
+ <script>
+
+ require([
+ 'echarts',
+ 'theme/infographic'
+ // 'echarts/chart/line',
+ // 'echarts/component/title',
+ // 'echarts/component/legend',
+ // 'echarts/component/grid',
+ // 'echarts/component/tooltip',
+ // 'echarts/component/dataZoomInside',
+ // 'zrender/svg/svg'
+ ], function (echarts) {
+
+ var chart = echarts.init(document.getElementById('main'));
+ chart.setOption(option = {
+ xAxis: {
+ type: 'category',
+ data: ['Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat', 'Sun']
+ },
+ yAxis: {
+ type: 'value'
+ },
+ series: [{
+ data: [{value:22},null,{value:33},26,{value:38},{value:33}],
+ type: 'line'
+ }]
+ });
+
+ window.onresize = chart.resize;
+ })
+
+ </script>
+ </body>
+</html>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org