You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2018/01/02 22:29:13 UTC

[kudu-CR] move configuration constants into separate class and make public

David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8920 )

Change subject: move configuration constants into separate class and make public
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8920/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8920/1//COMMIT_MSG@7
PS1, Line 7: move configuration constants into separate class and make public
           : 
           : Change-Id: I64f9ae5c2bc21ddaf757530a33642bd18cd774bf
Capitalize "Move" add a description and motive for the change.

Might be valuable to look at other commit messages to get a measure of what the "standard" is.



-- 
To view, visit http://gerrit.cloudera.org:8080/8920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f9ae5c2bc21ddaf757530a33642bd18cd774bf
Gerrit-Change-Number: 8920
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 02 Jan 2018 22:29:13 +0000
Gerrit-HasComments: Yes