You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/26 22:21:12 UTC
[GitHub] [superset] betodealmeida commented on a change in pull request #15846: feat: call screenshot to store `query_context`
betodealmeida commented on a change in pull request #15846:
URL: https://github.com/apache/superset/pull/15846#discussion_r676982761
##########
File path: superset-frontend/src/explore/components/PropertiesModal/index.tsx
##########
@@ -82,26 +81,6 @@ export default function PropertiesModal({
label: `${owner.first_name} ${owner.last_name}`,
})),
);
-
- if (chart.query_context === null) {
Review comment:
@hughhhh I had to move this to `ExploreChartPanel.jsx` because the screenshot calls the standalone version of the chart, and the screenshot request was not hitting this part of the code.
##########
File path: superset-frontend/src/explore/components/PropertiesModal/index.tsx
##########
@@ -82,26 +81,6 @@ export default function PropertiesModal({
label: `${owner.first_name} ${owner.last_name}`,
})),
);
-
- if (chart.query_context === null) {
Review comment:
@hughhhh I had to move this to `ExploreChartPanel.jsx` because the screenshot calls the standalone version of the chart, and the request was not hitting this part of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org