You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/04/01 01:54:15 UTC

[GitHub] [iotdb] neuyilan commented on a change in pull request #2864: [IOTDB-1230]Support cross multi time partition when loading one TsFile

neuyilan commented on a change in pull request #2864:
URL: https://github.com/apache/iotdb/pull/2864#discussion_r605326191



##########
File path: example/tsfile/src/main/java/org/apache/iotdb/tsfile/TsFileRead.java
##########
@@ -39,7 +39,8 @@
  * TsFileWriteWithTSRecord or TsFileWriteWithTablet to generate the test.tsfile first
  */
 public class TsFileRead {
-  private static final String DEVICE1 = "device_1";
+
+  private static final String DEVICE1 = Constant.STORAGE_GROUP + ".device_1";

Review comment:
       This is because in the TsFileWriteWithTablet class, the code write tsfile use root.sg info. if we write use the class and read use TsFileRead class, it will not work.
   So in this case, I will remove the storage info in TsFileWriteWithTablet class.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org