You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/09/05 09:34:14 UTC
[GitHub] [incubator-pekko-http] mdedetrich opened a new pull request, #313: Use fetch tags from latest checkout action
mdedetrich opened a new pull request, #313:
URL: https://github.com/apache/incubator-pekko-http/pull/313
The latest version of the checkout github actions now supports a `fetch-tags` flag which does as described, i.e. it will fetch all of our tags which removes the various workarounds that was used before (i.e. manually running `git fetch` command) etc etc, see https://github.com/actions/checkout/pull/579
This will also help in the erroneous errors that we get in CI, i.e.
```
[error] Failed to derive version from git tags. Maybe run `git fetch --unshallow` or `git fetch upstream` on a fresh git clone from a fork? Derived version: 0.0.0+1-337943bd-SNAPSHOT`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #313: Use fetch tags from latest checkout action
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #313:
URL: https://github.com/apache/incubator-pekko-http/pull/313#discussion_r1315901027
##########
.github/workflows/format.yml:
##########
@@ -13,9 +13,10 @@ jobs:
if: github.repository == 'apache/incubator-pekko-http'
steps:
- name: Checkout current branch (full)
- uses: actions/checkout@v3
+ uses: actions/checkout@v4
Review Comment:
Yes, I think it should be here in pekko-http. If its not I will add it in later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] He-Pin commented on a diff in pull request #313: Use fetch tags from latest checkout action
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #313:
URL: https://github.com/apache/incubator-pekko-http/pull/313#discussion_r1315684065
##########
.github/workflows/format.yml:
##########
@@ -13,9 +13,10 @@ jobs:
if: github.repository == 'apache/incubator-pekko-http'
steps:
- name: Checkout current branch (full)
- uses: actions/checkout@v3
+ uses: actions/checkout@v4
Review Comment:
Can we add a dependency-bot, is that allowed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich merged pull request #313: Use fetch tags from latest checkout action
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #313:
URL: https://github.com/apache/incubator-pekko-http/pull/313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org