[GitHub] [beam] lukecwik commented on a change in pull request #12519: [BEAM-10670] Make Read execute as a splittable DoFn by default for the Java DirectRunner.

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #12519:
URL: https://github.com/apache/beam/pull/12519#discussion_r468171726



##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/io/TextIOReadTest.java
##########
@@ -495,24 +487,6 @@ public void testReadDisplayData() {
       assertThat(displayData, hasDisplayItem("compressionType", BZIP2.toString()));
     }
 
-    @Test
-    @Category(ValidatesRunner.class)
-    public void testPrimitiveReadDisplayData() {

Review comment:
       Effectively a duplicate of `testReadDisplayData` just above.

##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/io/TFRecordIOTest.java
##########
@@ -209,15 +208,13 @@ public void testWriteTwo() throws Exception {
   @Test
   @Category(NeedsRunner.class)
   public void testReadInvalidRecord() throws Exception {
-    expectedException.expect(IllegalStateException.class);

Review comment:
       (here and below) This was previously throwing the top level exception but DirectRunner wraps ParDo exceptions with PipelineExecutionException but BoundedSource/UnboundedSource used a different code path and hence a different exception handling path.

##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/io/AvroIOTest.java
##########
@@ -1494,26 +1488,5 @@ public void testAvroSinkShardedWrite() throws Exception {
     }
     // TODO: for Write only, test withSuffix,
     // withShardNameTemplate and withoutSharding.
-
-    @Test
-    @Category(ValidatesRunner.class)
-    public void testPrimitiveReadDisplayData() {

Review comment:
       This is effectively a duplicate of `AvroIOTest$SimpleTests.testReadDisplayData` and doesn't need to a be a validates runner test since it doesn't run a pipeline.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org