You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sebastian (JIRA)" <ji...@apache.org> on 2019/05/16 06:42:00 UTC

[jira] [Commented] (WICKET-6656) JSR 303 - @NotNull validation problems

    [ https://issues.apache.org/jira/browse/WICKET-6656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841033#comment-16841033 ] 

Sebastian commented on WICKET-6656:
-----------------------------------

Hi Sven, I got another question. Is it possible to make the method 

PropertyValidator#isRequired protected? In this case it is more easy to implement a custom PropertyValidator and reuse more methods.
Thank you, Sebastian

> JSR 303 - @NotNull validation problems 
> ---------------------------------------
>
>                 Key: WICKET-6656
>                 URL: https://issues.apache.org/jira/browse/WICKET-6656
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-bean-validation
>    Affects Versions: 9.0.0-M1, 8.4.0
>            Reporter: Sebastian
>            Assignee: Sven Meier
>            Priority: Minor
>             Fix For: 8.5.0, 9.0.0-M2
>
>
> Hi there,
> we are using JSR 303 validations. But regarding the NotNull validation, the behaviour differs from the other validations.
> On a validation-violation the given message key of NotNull isn't used.
> We recognized, that the method FormComponent.validate() contains a condition to check if the required flag of a FormComponent is set. If the flag is set to true NotNull JSR validations aren't validated.
> On the other hand there is a default validator org.apache.wicket.bean.validation.PropertyValidator (wicket-bean-validation) which sets the required field to true if there is a NotNull validation added to a field.
> If we want to get full JSR 303 support, we need to implement INullAcceptingValidator. But this requires that the required field of FormComponent will always be false.
> The problem is, that we use the required field beside validation for some other functionality in the rendering phase.
> It would be very helpful, if Wicket completly supports JSR 303 without having a restriction on the usage of the FormComponent.
> Do you have a suggestion regarding this issue?
>  
> Thank you.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)