You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/05 10:53:46 UTC
[GitHub] [skywalking-java] heihei180 opened a new pull request, #376: add plugin support apache EventMesh
heihei180 opened a new pull request, #376:
URL: https://github.com/apache/skywalking-java/pull/376
Closes : #9910
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] heihei180 commented on a diff in pull request #376: add plugin support apache EventMesh
Posted by GitBox <gi...@apache.org>.
heihei180 commented on code in PR #376:
URL: https://github.com/apache/skywalking-java/pull/376#discussion_r1014973591
##########
apm-sniffer/apm-sdk-plugin/eventmesh-1.x-plugin/pom.xml:
##########
@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>apm-sdk-plugin</artifactId>
+ <groupId>org.apache.skywalking</groupId>
+ <version>8.13.0-SNAPSHOT</version>
Review Comment:
ok, i will do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng closed pull request #376: add plugin support apache EventMesh
Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #376: add plugin support apache EventMesh
URL: https://github.com/apache/skywalking-java/pull/376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #376: add plugin support apache EventMesh
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #376:
URL: https://github.com/apache/skywalking-java/pull/376#issuecomment-1322862767
No update in 15 days, close for now. If you want to continue working on this, please let use know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #376: add plugin support apache EventMesh
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #376:
URL: https://github.com/apache/skywalking-java/pull/376#discussion_r1014623928
##########
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java:
##########
@@ -231,4 +231,6 @@ public class ComponentsDefine {
public static final OfficialComponent IMPALA_JDBC_DRIVER = new OfficialComponent(133, "Impala-jdbc-driver");
+ public static final OfficialComponent EVENT_MESH = new OfficialComponent(134, "EventMesh");
Review Comment:
This ID should be registered in the main repository first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] heihei180 commented on pull request #376: add plugin support apache EventMesh
Posted by GitBox <gi...@apache.org>.
heihei180 commented on PR #376:
URL: https://github.com/apache/skywalking-java/pull/376#issuecomment-1304702819
i could't upload the `eventMesh` logo file . because the repository https://github.com/apache/skywalking-rocketbot-ui.git is archived
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #376: add plugin support apache EventMesh
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #376:
URL: https://github.com/apache/skywalking-java/pull/376#issuecomment-1315460970
Marked as stale as no update for a while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #376: add plugin support apache EventMesh
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #376:
URL: https://github.com/apache/skywalking-java/pull/376#issuecomment-1304497980
Hi,thanks for the contribution.
You are required to follow plugin dev doc to submit test scenarios to help us verifying the plugin in the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] heihei180 commented on pull request #376: add plugin support apache EventMesh
Posted by GitBox <gi...@apache.org>.
heihei180 commented on PR #376:
URL: https://github.com/apache/skywalking-java/pull/376#issuecomment-1304499324
> Hi,thanks for the contribution. You are required to follow plugin dev doc to submit test scenarios to help us verifying the plugin in the CI.
ok, i will do later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #376: add plugin support apache EventMesh
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #376:
URL: https://github.com/apache/skywalking-java/pull/376#issuecomment-1304504258
https://skywalking.apache.org/docs/main/next/en/setup/service-agent/virtual-mq/
And tags are required, and peer should be set at consumer and producer sides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #376: add plugin support apache EventMesh
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #376:
URL: https://github.com/apache/skywalking-java/pull/376#discussion_r1014763021
##########
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java:
##########
@@ -231,4 +231,6 @@ public class ComponentsDefine {
public static final OfficialComponent IMPALA_JDBC_DRIVER = new OfficialComponent(133, "Impala-jdbc-driver");
+ public static final OfficialComponent EVENT_MESH = new OfficialComponent(134, "EventMesh");
Review Comment:
https://github.com/apache/skywalking/blob/6984bbc65a4c12009e095e376b5e6ffb3a90db59/oap-server/server-starter/src/main/resources/component-libraries.yml#L434-L436
134 had been registered as Impala server, this is why we required for pre-registration before agent plugin PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] pg-yang commented on pull request #376: add plugin support apache EventMesh
Posted by GitBox <gi...@apache.org>.
pg-yang commented on PR #376:
URL: https://github.com/apache/skywalking-java/pull/376#issuecomment-1304704507
The current ui repo is https://github.com/apache/skywalking-booster-ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #376: add plugin support apache EventMesh
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #376:
URL: https://github.com/apache/skywalking-java/pull/376#discussion_r1014972360
##########
apm-sniffer/apm-sdk-plugin/eventmesh-1.x-plugin/pom.xml:
##########
@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>apm-sdk-plugin</artifactId>
+ <groupId>org.apache.skywalking</groupId>
+ <version>8.13.0-SNAPSHOT</version>
Review Comment:
Please sync to the main branch, and you need to use `8.14.0-SNAPSHOT`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org