[GitHub] [hudi] pratyakshsharma commented on a diff in pull request #6926: [HUDI-3676] Enhance tests for trigger clean every Nth commit

[GitBox <gi...@apache.org>]

pratyakshsharma commented on code in PR #6926:
URL: https://github.com/apache/hudi/pull/6926#discussion_r1007197479


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestCleanPlanExecutor.java:
##########
@@ -99,6 +99,206 @@ private static Stream<Arguments> argumentsForTestKeepLatestCommits() {
     );
   }
 
+  private static Stream<Arguments> argumentsForTestTriggerCleanEveryNCommits() {
+    return Stream.of(
+            Arguments.of(1),
+                Arguments.of(2),
+                Arguments.of(3),
+                Arguments.of(4)
+    );
+  }
+
+  @ParameterizedTest
+  @MethodSource("argumentsForTestTriggerCleanEveryNCommits")

Review Comment:
   so this method is intended to supply the values for the config `hoodie.clean.max.commits` with the documentation `Number of commits after the last clean operation, before scheduling of a new clean is attempted.` Hence I kept this name. @yihua 
   
   I am open to hearing your thoughts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org