You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Ryan McKinley (JIRA)" <ji...@apache.org> on 2007/12/16 19:44:43 UTC
[jira] Created: (SOLR-436) Make SolrServer an abstract superclass
rather then an interface
Make SolrServer an abstract superclass rather then an interface
---------------------------------------------------------------
Key: SOLR-436
URL: https://issues.apache.org/jira/browse/SOLR-436
Project: Solr
Issue Type: Improvement
Components: clients - java
Affects Versions: 1.3
Reporter: Ryan McKinley
Fix For: 1.3
To allow more flexability in the future, SolrServer should be an abstract super class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-436) Make SolrServer an abstract superclass
rather then an interface
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-436:
-------------------------------
Attachment: SOLR-436-AbstractSolrj.patch
moves BaseSolrServer to the SolrServer implementaion
> Make SolrServer an abstract superclass rather then an interface
> ---------------------------------------------------------------
>
> Key: SOLR-436
> URL: https://issues.apache.org/jira/browse/SOLR-436
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 1.3
> Reporter: Ryan McKinley
> Fix For: 1.3
>
> Attachments: SOLR-436-AbstractSolrj.patch
>
>
> To allow more flexability in the future, SolrServer should be an abstract super class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SOLR-436) Make SolrServer an abstract superclass
rather then an interface
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley reassigned SOLR-436:
----------------------------------
Assignee: Ryan McKinley
> Make SolrServer an abstract superclass rather then an interface
> ---------------------------------------------------------------
>
> Key: SOLR-436
> URL: https://issues.apache.org/jira/browse/SOLR-436
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 1.3
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 1.3
>
> Attachments: SOLR-436-AbstractSolrj.patch
>
>
> To allow more flexability in the future, SolrServer should be an abstract super class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-436) Make SolrServer an abstract superclass
rather then an interface
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley resolved SOLR-436.
--------------------------------
Resolution: Fixed
> Make SolrServer an abstract superclass rather then an interface
> ---------------------------------------------------------------
>
> Key: SOLR-436
> URL: https://issues.apache.org/jira/browse/SOLR-436
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 1.3
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 1.3
>
> Attachments: SOLR-436-AbstractSolrj.patch
>
>
> To allow more flexability in the future, SolrServer should be an abstract super class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-436) Make SolrServer an abstract superclass
rather then an interface
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561787#action_12561787 ]
Yonik Seeley commented on SOLR-436:
-----------------------------------
I don't think the abstract class / interface issue matters as much when we are going to be the only implementers of the interface.
> Make SolrServer an abstract superclass rather then an interface
> ---------------------------------------------------------------
>
> Key: SOLR-436
> URL: https://issues.apache.org/jira/browse/SOLR-436
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 1.3
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 1.3
>
> Attachments: SOLR-436-AbstractSolrj.patch
>
>
> To allow more flexability in the future, SolrServer should be an abstract super class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-436) Make SolrServer an abstract superclass
rather then an interface
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561802#action_12561802 ]
Ryan McKinley commented on SOLR-436:
------------------------------------
Even if we are the only implementation, how do you add functions after a release? Is it just that the standard compatibility rules would not apply?
> Make SolrServer an abstract superclass rather then an interface
> ---------------------------------------------------------------
>
> Key: SOLR-436
> URL: https://issues.apache.org/jira/browse/SOLR-436
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 1.3
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 1.3
>
> Attachments: SOLR-436-AbstractSolrj.patch
>
>
> To allow more flexability in the future, SolrServer should be an abstract super class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-436) Make SolrServer an abstract superclass
rather then an interface
Posted by "Alexander Ramos Jardim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603578#action_12603578 ]
Alexander Ramos Jardim commented on SOLR-436:
---------------------------------------------
As I said on the mailing list, I don't think interfaces should be turned to abstract classes. This is a wrong design decision from a pure programming view point as interfaces should expose what abstract classes implements. They are complements and not competitors.
I think we should have a SolrServer interface and an AbstractSolrServer that implements it.
Methods should be added to AbstractSolrServer on minor releases, and on each major release, the interface signature should be changed to expose them in an adequate manner.
> Make SolrServer an abstract superclass rather then an interface
> ---------------------------------------------------------------
>
> Key: SOLR-436
> URL: https://issues.apache.org/jira/browse/SOLR-436
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 1.3
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 1.3
>
> Attachments: SOLR-436-AbstractSolrj.patch
>
>
> To allow more flexability in the future, SolrServer should be an abstract super class
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.