You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/23 14:22:03 UTC

[GitHub] [tvm] Lunderberg commented on a change in pull request #10712: [NDArray] Expose NDArray::CreateView to python

Lunderberg commented on a change in pull request #10712:
URL: https://github.com/apache/tvm/pull/10712#discussion_r833328440



##########
File path: python/tvm/runtime/ndarray.py
##########
@@ -249,6 +249,20 @@ def copyto(self, target):
             return self._copyto(res)
         raise ValueError("Unsupported target type %s" % str(type(target)))
 
+    def create_view(self, shape):
+        shape_imm = []

Review comment:
       Thank you, and that cleans it up quite a bit.  I had been using the same calling convention as `TVMArrayAllocWithScope`, called from `tvm.runtime.ndarray.empty`, which predates `ShapeTuple`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org