You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/26 00:38:51 UTC
[GitHub] [spark] dongjoon-hyun commented on issue #26261: [SPARK-29607][SQL]
Move static methods from CalendarInterval to IntervalUtils
dongjoon-hyun commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
URL: https://github.com/apache/spark/pull/26261#issuecomment-546552202
@MaxGekk . I left a few minor comments. In general, the logic is correctly migrated from Java to Scala.
And, I agree with @MaxGekk 's opinion. How do you think about this, @cloud-fan ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org