You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/03/28 00:49:47 UTC
[kudu-CR] java: round out log4j.properties in all modules
Hello Will Berkeley, Mike Percy, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12873
to review the following change.
Change subject: java: round out log4j.properties in all modules
......................................................................
java: round out log4j.properties in all modules
These modules were missing log4j.properties, which means their tests didn't
log anything. Let's fix that.
Change-Id: I162a9bb63b3d9ed4a16193be51b21098a2a34db2
---
A java/kudu-client-tools/src/test/resources/log4j.properties
A java/kudu-flume-sink/src/test/resources/log4j.properties
A java/kudu-mapreduce/src/test/resources/log4j.properties
3 files changed, 69 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/12873/1
--
To view, visit http://gerrit.cloudera.org:8080/12873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I162a9bb63b3d9ed4a16193be51b21098a2a34db2
Gerrit-Change-Number: 12873
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] java: round out log4j.properties in all modules
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12873 )
Change subject: java: round out log4j.properties in all modules
......................................................................
java: round out log4j.properties in all modules
These modules were missing log4j.properties, which means their tests didn't
log anything. Let's fix that.
Change-Id: I162a9bb63b3d9ed4a16193be51b21098a2a34db2
Reviewed-on: http://gerrit.cloudera.org:8080/12873
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
A java/kudu-client-tools/src/test/resources/log4j.properties
A java/kudu-flume-sink/src/test/resources/log4j.properties
A java/kudu-mapreduce/src/test/resources/log4j.properties
3 files changed, 69 insertions(+), 0 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I162a9bb63b3d9ed4a16193be51b21098a2a34db2
Gerrit-Change-Number: 12873
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] java: round out log4j.properties in all modules
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12873 )
Change subject: java: round out log4j.properties in all modules
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I162a9bb63b3d9ed4a16193be51b21098a2a34db2
Gerrit-Change-Number: 12873
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Mar 2019 01:19:43 +0000
Gerrit-HasComments: No