You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/06/24 03:49:47 UTC

[GitHub] [incubator-seatunnel] lhyundeadsoul opened a new pull request, #2055: Assertsink4apidraft

lhyundeadsoul opened a new pull request, #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [x] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055#discussion_r905938779


##########
pom.xml:
##########
@@ -433,6 +434,11 @@
                 <artifactId>commons-lang3</artifactId>
                 <version>${commons-lang3.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.apache.commons</groupId>
+                <artifactId>commons-collections4</artifactId>
+                <version>${commons-collections4.version}</version>
+            </dependency>

Review Comment:
   please add license files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] lhyundeadsoul commented on a diff in pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on code in PR #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055#discussion_r905993237


##########
pom.xml:
##########
@@ -433,6 +434,11 @@
                 <artifactId>commons-lang3</artifactId>
                 <version>${commons-lang3.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.apache.commons</groupId>
+                <artifactId>commons-collections4</artifactId>
+                <version>${commons-collections4.version}</version>
+            </dependency>

Review Comment:
   > you can refer this https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md
   
   I have 2 questions after trying add new license refering this page.
   1. I got following message after the 3rd step.  Is this normal?
   ```
   > $ python3 tools/dependencies/license.py seatunnel-dist/target/THIRD-PARTY.txt seatunnel-dist/release-docs/LICENSE true                                                                                                                                      [±assertsink4apidraft ●]
   
   (Unknown license) jsch (com.jcraft:jsch:0.1.54 - no url defined)
   (Unknown license) disruptor (com.lmax:disruptor:3.3.6 - no url defined)
   (Unknown license) Commons IO (commons-io:commons-io:2.4 - http://commons.apache.org/io/)
   (Unknown license) commons-net (commons-net:commons-net:3.6 - no url defined)
   (Unknown license) joda-time (joda-time:joda-time:1.6 - no url defined)
   (Unknown license) "Java Concurrency in Practice" book annotations (net.jcip:jcip-annotations:1.0 - http://jcip.net/)
   (Unknown license) stringtemplate (org.antlr:stringtemplate:3.2.1 - no url defined)
   (Unknown license) libthrift (org.apache.thrift:libthrift:0.9.0 - no url defined)
   (Bouncy Castle Licence) Bouncy Castle PKIX, CMS, EAC, TSP, PKCS, OCSP, CMP, and CRMF APIs (org.bouncycastle:bcpkix-jdk15on:1.68 - http://www.bouncycastle.org/java.html)
   (Bouncy Castle Licence) Bouncy Castle Provider (org.bouncycastle:bcprov-ext-jdk15on:1.68 - https://www.bouncycastle.org/java.html)
   (Bouncy Castle Licence) Bouncy Castle Provider (org.bouncycastle:bcprov-jdk15on:1.68 - http://www.bouncycastle.org/java.html)
   (Unknown license) xz (org.tukaani:xz:1.5 - no url defined)
   (Unknown license) stax-api (stax:stax-api:1.0.1 - no url defined)
   Please confirm the license by finding LICENSE file in the corresponding Jar file and maintain it in the dependency_licenses_map instance.
   
   ```
   2. There is no detail instruction in 4th step. I don't know what to do for this step.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055#discussion_r907948239


##########
pom.xml:
##########
@@ -433,6 +434,11 @@
                 <artifactId>commons-lang3</artifactId>
                 <version>${commons-lang3.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.apache.commons</groupId>
+                <artifactId>commons-collections4</artifactId>
+                <version>${commons-collections4.version}</version>
+            </dependency>

Review Comment:
   If there are no other considerations, you just need to modify `common-collections.version` to 4.2, which is already used  4.2 in our project;



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] lhyundeadsoul commented on a diff in pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on code in PR #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055#discussion_r905977689


##########
pom.xml:
##########
@@ -433,6 +434,11 @@
                 <artifactId>commons-lang3</artifactId>
                 <version>${commons-lang3.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.apache.commons</groupId>
+                <artifactId>commons-collections4</artifactId>
+                <version>${commons-collections4.version}</version>
+            </dependency>

Review Comment:
   Thanks for reviewing.  @CalvinKirs  But how to add licenses according to standard procedures? Thx again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] lhyundeadsoul commented on a diff in pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on code in PR #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055#discussion_r905993237


##########
pom.xml:
##########
@@ -433,6 +434,11 @@
                 <artifactId>commons-lang3</artifactId>
                 <version>${commons-lang3.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.apache.commons</groupId>
+                <artifactId>commons-collections4</artifactId>
+                <version>${commons-collections4.version}</version>
+            </dependency>

Review Comment:
   > you can refer this https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md
   
   I have 2 questions after trying add new license refering this page.
   1. I got following message after the 3rd step.  Is this normal?
   ```
   > $ python3 tools/dependencies/license.py seatunnel-dist/target/THIRD-PARTY.txt seatunnel-dist/release-docs/LICENSE true                                                                                                                                      [±assertsink4apidraft ●]
   
   (Unknown license) jsch (com.jcraft:jsch:0.1.54 - no url defined)
   (Unknown license) disruptor (com.lmax:disruptor:3.3.6 - no url defined)
   (Unknown license) Commons IO (commons-io:commons-io:2.4 - http://commons.apache.org/io/)
   (Unknown license) commons-net (commons-net:commons-net:3.6 - no url defined)
   (Unknown license) joda-time (joda-time:joda-time:1.6 - no url defined)
   (Unknown license) "Java Concurrency in Practice" book annotations (net.jcip:jcip-annotations:1.0 - http://jcip.net/)
   (Unknown license) stringtemplate (org.antlr:stringtemplate:3.2.1 - no url defined)
   (Unknown license) libthrift (org.apache.thrift:libthrift:0.9.0 - no url defined)
   (Bouncy Castle Licence) Bouncy Castle PKIX, CMS, EAC, TSP, PKCS, OCSP, CMP, and CRMF APIs (org.bouncycastle:bcpkix-jdk15on:1.68 - http://www.bouncycastle.org/java.html)
   (Bouncy Castle Licence) Bouncy Castle Provider (org.bouncycastle:bcprov-ext-jdk15on:1.68 - https://www.bouncycastle.org/java.html)
   (Bouncy Castle Licence) Bouncy Castle Provider (org.bouncycastle:bcprov-jdk15on:1.68 - http://www.bouncycastle.org/java.html)
   (Unknown license) xz (org.tukaani:xz:1.5 - no url defined)
   (Unknown license) stax-api (stax:stax-api:1.0.1 - no url defined)
   Please confirm the license by finding LICENSE file in the corresponding Jar file and maintain it in the dependency_licenses_map instance.
   
   ```
   2. There is no detail instruction in 4th step. I don't know how to do for this step.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055#issuecomment-1169505787

   Close this PR, change to #2071 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X closed pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
Hisoka-X closed pull request #2055: [api-draft][connectors]add Assert sink to api-draft
URL: https://github.com/apache/incubator-seatunnel/pull/2055


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] lhyundeadsoul commented on pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on PR #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055#issuecomment-1165263218

   PTAL @ruanwenjun Thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] lhyundeadsoul commented on a diff in pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on code in PR #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055#discussion_r905989788


##########
pom.xml:
##########
@@ -433,6 +434,11 @@
                 <artifactId>commons-lang3</artifactId>
                 <version>${commons-lang3.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.apache.commons</groupId>
+                <artifactId>commons-collections4</artifactId>
+                <version>${commons-collections4.version}</version>
+            </dependency>

Review Comment:
   `org.apache.commons:commons-collections4:4.4` is already in `seatunnel-dist/release-docs/LICENSE`. Is that ok?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] lhyundeadsoul commented on a diff in pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on code in PR #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055#discussion_r905989788


##########
pom.xml:
##########
@@ -433,6 +434,11 @@
                 <artifactId>commons-lang3</artifactId>
                 <version>${commons-lang3.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.apache.commons</groupId>
+                <artifactId>commons-collections4</artifactId>
+                <version>${commons-collections4.version}</version>
+            </dependency>

Review Comment:
   `commons-collections4-4.4.jar` is already in `known-dependencies-jdk8.txt`
   `org.apache.commons:commons-collections4:4.4` is already in `seatunnel-dist/release-docs/LICENSE`.
   
    Is that ok?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055#discussion_r905946210


##########
pom.xml:
##########
@@ -433,6 +434,11 @@
                 <artifactId>commons-lang3</artifactId>
                 <version>${commons-lang3.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.apache.commons</groupId>
+                <artifactId>commons-collections4</artifactId>
+                <version>${commons-collections4.version}</version>
+            </dependency>

Review Comment:
   you can refer this https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] lhyundeadsoul commented on a diff in pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on code in PR #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055#discussion_r907993033


##########
pom.xml:
##########
@@ -433,6 +434,11 @@
                 <artifactId>commons-lang3</artifactId>
                 <version>${commons-lang3.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.apache.commons</groupId>
+                <artifactId>commons-collections4</artifactId>
+                <version>${commons-collections4.version}</version>
+            </dependency>

Review Comment:
   > If there are no other considerations, you just need to modify `common-collections.version` to 4.2, which is already used 4.2 in our project;
   
   ok, Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] lhyundeadsoul commented on pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on PR #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055#issuecomment-1168465514

   It seems a `AbstractSimpleSink` was added. I need to extend it, right? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] lhyundeadsoul commented on pull request #2055: [api-draft][connectors]add Assert sink to api-draft

Posted by GitBox <gi...@apache.org>.
lhyundeadsoul commented on PR #2055:
URL: https://github.com/apache/incubator-seatunnel/pull/2055#issuecomment-1168532259

   I don't know why there are so many other's commit in my PR. so I create another PR  https://github.com/apache/incubator-seatunnel/pull/2071


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org