[jira] [Work logged] (IO-696) IOUtils.toByteArray throws inconsistent exceptions

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IO-696?focusedWorklogId=530607&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530607 ]

ASF GitHub Bot logged work on IO-696:
-------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jan/21 10:56
            Start Date: 04/Jan/21 10:56
    Worklog Time Spent: 10m 
      Work Description: abchaubey opened a new pull request #181:
URL: https://github.com/apache/commons-io/pull/181


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 530607)
    Remaining Estimate: 0h
            Time Spent: 10m

> IOUtils.toByteArray throws inconsistent exceptions
> --------------------------------------------------
>
>                 Key: IO-696
>                 URL: https://issues.apache.org/jira/browse/IO-696
>             Project: Commons IO
>          Issue Type: Bug
>            Reporter: ackelcn
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The code of this method is as follows:
> {code:java}
> public static byte[] toByteArray(final InputStream input, final int size) throws IOException {        
>       if (size < 0) {
>             throw new IllegalArgumentException("Size must be equal or greater than zero: " + size);
>         }        if (size == 0) {
>             return new byte[0];
>         }        final byte[] data = new byte[size];
>         int offset = 0;
>         int read;        while (offset < size && (read = input.read(data, offset, size - offset)) != EOF) {
>             offset += read;
>         }        
>         if (offset != size) {
>             throw new IOException("Unexpected read size. current: " + offset + ", expected: " + size);
>         }        return data;
>     }
> {code}
> When size is below zero, it throws IllegalArgumentException, but when size is not equal to offset, it throws IOException. It is somewhat confusing. It shall throw IOException in both cases, in that both cases check legal sizes. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)