[GitHub] spark pull request: [SPARK-15550][SQL] Dataset.show() should show ...

[liancheng <gi...@git.apache.org>]

Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13331#discussion_r64816282
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala ---
    @@ -436,20 +435,6 @@ class DatasetSuite extends QueryTest with SharedSQLContext {
         assert(ds.toString == "[_1: int, _2: int]")
       }
     
    -  test("showString: Kryo encoder") {
    -    implicit val kryoEncoder = Encoders.kryo[KryoData]
    -    val ds = Seq(KryoData(1), KryoData(2)).toDS()
    -
    -    val expectedAnswer = """+-----------+
    -                           ||      value|
    -                           |+-----------+
    -                           ||KryoData(1)|
    -                           ||KryoData(2)|
    -                           |+-----------+
    -                           |""".stripMargin
    -    assert(ds.showString(10) === expectedAnswer)
    -  }
    -
    --- End diff --
    
    Removed this test case since we are not showing objects serialized by Kryo using `toString`. It's just a normal binary column now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org