You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/03/07 13:58:40 UTC

[jira] [Commented] (TAP5-2537) ApplicationStateManagerImpl.getIfExists() fails when session is invalid (on Jetty, at least)

    [ https://issues.apache.org/jira/browse/TAP5-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182968#comment-15182968 ] 

ASF subversion and git services commented on TAP5-2537:
-------------------------------------------------------

Commit c4c83a8bfe86a1d1ebe055f83a992933f7c6e5e4 in tapestry-5's branch refs/heads/master from [~jkemnade]
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=c4c83a8 ]

TAP5-2537: avoid an IllegalStateException when trying to get an attribute from an invalidates session


> ApplicationStateManagerImpl.getIfExists() fails when session is invalid (on Jetty, at least)
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-2537
>                 URL: https://issues.apache.org/jira/browse/TAP5-2537
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: I D
>            Assignee: Jochen Kemnade
>             Fix For: 5.4.1
>
>
> An IllegalStateException is thrown when calling ApplicationStateManagerImpl.getIfExists() on an invalid session. I would expect the method to catch the exception and return null in this case.
> Stack trace (top only):
> {code:java}
> - org.eclipse.jetty.server.session.AbstractSession.checkValid(AbstractSession.java:106)
>   - org.eclipse.jetty.server.session.AbstractSession.getAttribute(AbstractSession.java:459)
>   - org.apache.tapestry5.internal.services.SessionImpl.getAttribute(SessionImpl.java:52)
>   - org.apache.tapestry5.internal.services.SessionApplicationStatePersistenceStrategy.exists(SessionApplicationStatePersistenceStrategy.java:80)
>   - $ApplicationStatePersistenceStrategy_b43cfdb8299.exists(Unknown Source)
>   - org.apache.tapestry5.internal.services.ApplicationStateManagerImpl$ApplicationStateAdapter.exists(ApplicationStateManagerImpl.java:60)
>   - org.apache.tapestry5.internal.services.ApplicationStateManagerImpl.getIfExists(ApplicationStateManagerImpl.java:140)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)