You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "m1a2st (via GitHub)" <gi...@apache.org> on 2024/10/19 16:16:55 UTC

[PR] KAFKA-17834 Improvement the e2e Dockerfile [kafka]

m1a2st opened a new pull request, #17554:
URL: https://github.com/apache/kafka/pull/17554

   Jira: https://issues.apache.org/jira/browse/KAFKA-17834
   
   This PR fixed thress dockerfile warning:
   1. MaintainerDeprecated
   2. LegacyKeyValueFormat
   3. JSONArgsRecommended
   
   If have any warning, It will show in console like 
   ![CleanShot 2024-10-19 at 23 59 02@2x](https://github.com/user-attachments/assets/b9577099-a873-4a11-8c18-4c984fc672f5)
   
   I ran on my local machine: It won't show any warning
   ![CleanShot 2024-10-19 at 23 58 06@2x](https://github.com/user-attachments/assets/816eebc8-ccf9-477b-8d0c-fc1decf2e016)
   
   The e2e test also can run and pass
   ![CleanShot 2024-10-20 at 00 16 36@2x](https://github.com/user-attachments/assets/d42cc0ef-7ecc-411c-a4b0-f3e09e3ef896)
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-17834 Improvement the e2e Dockerfile [kafka]

Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on code in PR #17554:
URL: https://github.com/apache/kafka/pull/17554#discussion_r1846518757


##########
tests/docker/Dockerfile:
##########
@@ -153,4 +153,4 @@ RUN useradd -u $UID -ms /bin/bash ducker \
 
 USER ducker
 
-CMD sudo service ssh start && tail -f /dev/null

Review Comment:
   Yes, it can pass on my local 
   ![image](https://github.com/user-attachments/assets/d08147b9-40b1-4585-afd3-156d7ea942b8)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-17834 Improvement the e2e Dockerfile [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #17554:
URL: https://github.com/apache/kafka/pull/17554#issuecomment-2508335681

   @m1a2st Could you please rebase code?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-17834 Improvement the e2e Dockerfile [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #17554:
URL: https://github.com/apache/kafka/pull/17554#issuecomment-2481713588

   reference:
   
   `MaintainerDeprecated`: https://docs.docker.com/reference/build-checks/maintainer-deprecated/
   `LegacyKeyValueFormat`: https://docs.docker.com/reference/build-checks/legacy-key-value-format/
   `JSONArgsRecommended`: https://docs.docker.com/reference/build-checks/json-args-recommended/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-17834 Improvement the Dockerfile [kafka]

Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #17554:
URL: https://github.com/apache/kafka/pull/17554#issuecomment-3248561958

   @chia7712 Did you have other comments?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-17834 Improvement the Dockerfile [kafka]

Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #17554:
URL: https://github.com/apache/kafka/pull/17554


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-17834 Improvement the e2e Dockerfile [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17554:
URL: https://github.com/apache/kafka/pull/17554#discussion_r1845737954


##########
tests/docker/Dockerfile:
##########
@@ -153,4 +153,4 @@ RUN useradd -u $UID -ms /bin/bash ducker \
 
 USER ducker
 
-CMD sudo service ssh start && tail -f /dev/null

Review Comment:
   we use the `tail` to make the container alive, and that can be replaced by detaching the sshd. Hence, could you please try to use `CMD ["sudo", "service", "ssh", "start", "-D"]` instaead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org