You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Prasanna Santhanam <ts...@apache.org> on 2013/06/17 15:44:58 UTC

Re: Review Request: set rpcProvider field correctly in constructor

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11325/#review21980
-----------------------------------------------------------

Ship it!


3a02942

- Prasanna Santhanam


On May 22, 2013, 6:25 a.m., Dave Brosius wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11325/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 6:25 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> code does
> 
> rpcProvider = rpcProvider; which is a NOP, due to missing 'this." - patch adds that.
> 
> 
> Diffs
> -----
> 
>   engine/storage/src/org/apache/cloudstack/storage/HypervisorHostEndPointRpcServer.java bc21776 
> 
> Diff: https://reviews.apache.org/r/11325/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>