[GitHub] [rocketmq-client-cpp] yuz10 commented on a diff in pull request #451: [ISSUE #450] fix connect fail when connect concurrently

["yuz10 (via GitHub)" <gi...@apache.org>]

yuz10 commented on code in PR #451:
URL: https://github.com/apache/rocketmq-client-cpp/pull/451#discussion_r1218794362


##########
src/transport/TcpRemotingClient.cpp:
##########
@@ -319,8 +319,15 @@ std::shared_ptr<TcpTransport> TcpRemotingClient::CreateTransport(const string& a
         if (connectStatus == TCP_CONNECT_STATUS_SUCCESS) {
           return tcp;
         } else if (connectStatus == TCP_CONNECT_STATUS_WAIT) {
-          std::shared_ptr<TcpTransport> pTcp;
-          return pTcp;
+          connectStatus = tcp->waitTcpConnectEvent(static_cast<int>(m_tcpConnectTimeout));

Review Comment:
   Any suggustions? waitTcpConnectEvent is also called in the funtion if connection not in table



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org