You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/01 15:13:02 UTC
[GitHub] [airflow] jmcarp opened a new pull request #14006: Document configuration for email backend credentials.
jmcarp opened a new pull request #14006:
URL: https://github.com/apache/airflow/pull/14006
Document credentials configuration for email backends and add ses backend documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14006: Document configuration for email backend credentials.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14006:
URL: https://github.com/apache/airflow/pull/14006#discussion_r569005840
##########
File path: airflow/providers/amazon/aws/utils/emailer.py
##########
@@ -31,7 +31,7 @@ def send_email(
bcc: Optional[Union[List[str], str]] = None,
mime_subtype: str = 'mixed',
mime_charset: str = 'utf-8',
- conn_id: Optional[str] = None,
+ conn_id: str = 'ses_default',
Review comment:
All AWS integration should share common conn_id. See: https://github.com/apache/airflow/blob/master/UPDATING.md#normalize-gcp_conn_id-for-google-cloud
If the user needs it, he can define more complex configurations, but the default should assume that all AWS / GCP services have one credential.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14006: Document configuration for email backend credentials.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14006:
URL: https://github.com/apache/airflow/pull/14006#issuecomment-776468930
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jmcarp commented on pull request #14006: Document configuration for email backend credentials.
Posted by GitBox <gi...@apache.org>.
jmcarp commented on pull request #14006:
URL: https://github.com/apache/airflow/pull/14006#issuecomment-776445492
Thanks @mik-laj, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #14006: Document configuration for email backend credentials.
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #14006:
URL: https://github.com/apache/airflow/pull/14006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14006: Document configuration for email backend credentials.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14006:
URL: https://github.com/apache/airflow/pull/14006#issuecomment-771016268
[The Workflow run](https://github.com/apache/airflow/actions/runs/528068249) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14006: Document configuration for email backend credentials.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14006:
URL: https://github.com/apache/airflow/pull/14006#discussion_r569005840
##########
File path: airflow/providers/amazon/aws/utils/emailer.py
##########
@@ -31,7 +31,7 @@ def send_email(
bcc: Optional[Union[List[str], str]] = None,
mime_subtype: str = 'mixed',
mime_charset: str = 'utf-8',
- conn_id: Optional[str] = None,
+ conn_id: str = 'ses_default',
Review comment:
All AWS integration should share common conn_id. See: https://github.com/apache/airflow/blob/master/UPDATING.md#normalize-gcp_conn_id-for-google-cloud
If the user needs it, he can define more complex configurations, but the default should assume that all AWS / GCP services have one credential.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org