You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@polaris.apache.org by "flyrain (via GitHub)" <gi...@apache.org> on 2024/08/30 00:26:07 UTC

[PR] Fix scala version mismatch [polaris]

flyrain opened a new pull request, #235:
URL: https://github.com/apache/polaris/pull/235

   # Description
   
   Make sure the Scala version is the same to Fixes #234
   
   ## Type of change
   
   - [ ] Bug fix (non-breaking change which fixes an issue)
   
   # How Has This Been Tested?
   Validated with ./regtests/run_spark_sql.sh
   
   # Checklist:
   
   - [ ] I have performed a self-review of my code
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix scala version mismatch [polaris]

Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #235:
URL: https://github.com/apache/polaris/pull/235#discussion_r1737554030


##########
regtests/run.sh:
##########
@@ -20,7 +20,7 @@
 # Run without args to run all tests, or single arg for single test.
 
 export SPARK_VERSION=spark-3.5.2
-export SPARK_DISTRIBUTION=${SPARK_VERSION}-bin-hadoop3-scala2.13
+export SPARK_DISTRIBUTION=${SPARK_VERSION}-bin-hadoop3

Review Comment:
   If there is no particular reason to use scala 2.13, I would stick to the default one, which is 2.12.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix scala version mismatch [polaris]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #235:
URL: https://github.com/apache/polaris/pull/235


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org