You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/11 21:14:58 UTC
[GitHub] [bookkeeper] Ghatage commented on a change in pull request #2436: Detect Java 11 JRE and not only JDK
Ghatage commented on a change in pull request #2436:
URL: https://github.com/apache/bookkeeper/pull/2436#discussion_r502966657
##########
File path: bin/common.sh
##########
@@ -72,7 +72,7 @@ source ${BK_CONFDIR}/bk_cli_env.sh
detect_jdk8() {
- if [ -f "$JAVA_HOME/bin/jshell" ]; then
+ if [ -f "$JAVA_HOME/lib/modules" ]; then
Review comment:
Note: This is on a mac, is this script designed to be run on all platforms? @eolivelli
##########
File path: bin/common.sh
##########
@@ -72,7 +72,7 @@ source ${BK_CONFDIR}/bk_cli_env.sh
detect_jdk8() {
- if [ -f "$JAVA_HOME/bin/jshell" ]; then
+ if [ -f "$JAVA_HOME/lib/modules" ]; then
Review comment:
How does this differentiate between JDK8 and JDK11?
I see this for JDK11
```
~> ls $JAVA_HOME/lib/modules
/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/lib/modules
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org