[GitHub] [incubator-pagespeed-mod] Lofesa commented on issue #1857: firefox 65 png and gif files do not convert to webp, though jpg does.

[GitBox <gi...@apache.org>]

Lofesa commented on issue #1857: firefox 65 png and gif files do not convert to webp, though jpg does.
URL: https://github.com/apache/incubator-pagespeed-mod/issues/1857#issuecomment-570812465
 
 
   I´m testing Firefox nightly (73) and get some png (don´t use gif) not converted and others png converted to webp. My theory about that is that the issue is related to the alpha channel.
   I have found in the file: `pagespeed/kernel/image/image_converter.cc` this [line ](https://github.com/apache/incubator-pagespeed-mod/blob/b4bf44cc56d8bbf17494c540dfb6ef20dfcf5073/pagespeed/kernel/image/image_converter.cc#L346) so if the alpha channel is 0, the image is not converted.
   In other hand, in the file `pagespeed/kernel/http/user_agent_matcher.cc` there are a [whitelist](https://github.com/apache/incubator-pagespeed-mod/blob/b4bf44cc56d8bbf17494c540dfb6ef20dfcf5073/pagespeed/kernel/http/user_agent_matcher.cc#L157) for UA with support for webp alpha.
   So maybe including some like `"*Firefox/7*"` to the white list may do the trick.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services