You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/07/01 03:55:41 UTC
Review Request 36074: MESOS-2973: Allow ssl tests to run using
gtest_repeat.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36074/
-----------------------------------------------------------
Review request for mesos, Adam B and Benjamin Hindman.
Repository: mesos
Description
-------
The SSL ctx object carried some settings between reinitialize() calls. Re-construct the object to avoid this state transition.
Diffs
-----
3rdparty/libprocess/src/openssl.cpp 6ff4adb4c9792ff10d8c6ed2f3b2f3d8d0d7f1a8
3rdparty/libprocess/src/tests/ssl_tests.cpp c077aaeaecbe2cdcdad2b042741eeb8906699a22
Diff: https://reviews.apache.org/r/36074/diff/
Testing
-------
GTEST_FILTER="SSLTest.*" tests --gtest_repeat=100
Thanks,
Joris Van Remoortere
Re: Review Request 36074: MESOS-2973: Allow SSL tests to run using
gtest_repeat.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36074/#review90158
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 1, 2015, 2:26 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36074/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 2:26 a.m.)
>
>
> Review request for mesos, Adam B and Benjamin Hindman.
>
>
> Bugs: MESOS-2973
> https://issues.apache.org/jira/browse/MESOS-2973
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The SSL ctx object carried some settings between reinitialize() calls. Re-construct the object to avoid this state transition.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/openssl.cpp 6ff4adb4c9792ff10d8c6ed2f3b2f3d8d0d7f1a8
> 3rdparty/libprocess/src/tests/ssl_tests.cpp c077aaeaecbe2cdcdad2b042741eeb8906699a22
>
> Diff: https://reviews.apache.org/r/36074/diff/
>
>
> Testing
> -------
>
> GTEST_FILTER="SSLTest.*" tests --gtest_repeat=100
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36074: MESOS-2973: Allow SSL tests to run using
gtest_repeat.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36074/
-----------------------------------------------------------
(Updated July 1, 2015, 2:26 a.m.)
Review request for mesos, Adam B and Benjamin Hindman.
Bugs: MESOS-2973
https://issues.apache.org/jira/browse/MESOS-2973
Repository: mesos
Description
-------
The SSL ctx object carried some settings between reinitialize() calls. Re-construct the object to avoid this state transition.
Diffs
-----
3rdparty/libprocess/src/openssl.cpp 6ff4adb4c9792ff10d8c6ed2f3b2f3d8d0d7f1a8
3rdparty/libprocess/src/tests/ssl_tests.cpp c077aaeaecbe2cdcdad2b042741eeb8906699a22
Diff: https://reviews.apache.org/r/36074/diff/
Testing
-------
GTEST_FILTER="SSLTest.*" tests --gtest_repeat=100
Thanks,
Joris Van Remoortere
Re: Review Request 36074: MESOS-2973: Allow SSL tests to run using
gtest_repeat.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36074/
-----------------------------------------------------------
(Updated July 1, 2015, 2:24 a.m.)
Review request for mesos, Adam B and Benjamin Hindman.
Summary (updated)
-----------------
MESOS-2973: Allow SSL tests to run using gtest_repeat.
Repository: mesos
Description
-------
The SSL ctx object carried some settings between reinitialize() calls. Re-construct the object to avoid this state transition.
Diffs
-----
3rdparty/libprocess/src/openssl.cpp 6ff4adb4c9792ff10d8c6ed2f3b2f3d8d0d7f1a8
3rdparty/libprocess/src/tests/ssl_tests.cpp c077aaeaecbe2cdcdad2b042741eeb8906699a22
Diff: https://reviews.apache.org/r/36074/diff/
Testing
-------
GTEST_FILTER="SSLTest.*" tests --gtest_repeat=100
Thanks,
Joris Van Remoortere