You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/03 05:39:39 UTC
[GitHub] [pulsar] coderzc opened a new pull request, #16923: [fix][doc] fix `ackReceiptEnabled` doc
coderzc opened a new pull request, #16923:
URL: https://github.com/apache/pulsar/pull/16923
Fixes #16449
### Motivation
The add `ackReceiptEnabled` doc is not correct in PR #16465, need to correct the docs.
### Modifications
Fix `ackReceiptEnabled` doc.
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [x] `doc`
(Your PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #16923: [fix][doc] fix `ackReceiptEnabled` doc
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #16923:
URL: https://github.com/apache/pulsar/pull/16923#issuecomment-1228662908
Thanks for following up on this @coderzc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #16923: [fix][doc] fix `ackReceiptEnabled` doc
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #16923:
URL: https://github.com/apache/pulsar/pull/16923#issuecomment-1214294590
@codelipenghui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #16923: [fix][doc] fix `ackReceiptEnabled` doc
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #16923:
URL: https://github.com/apache/pulsar/pull/16923#issuecomment-1204849593
@michaeljmarshall @lhotari @Anonymitaet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on a diff in pull request #16923: [fix][doc] fix `ackReceiptEnabled` doc
Posted by GitBox <gi...@apache.org>.
coderzc commented on code in PR #16923:
URL: https://github.com/apache/pulsar/pull/16923#discussion_r940128454
##########
site2/docs/client-libraries-java.md:
##########
@@ -744,7 +744,7 @@ When you create a consumer, you can use the `loadConf` configuration. The follow
`autoAckOldestChunkedMessageOnQueueFull`|boolean|Whether to automatically acknowledge pending chunked messages when the threashold of `maxPendingChunkedMessage` is reached. If set to `false`, these messages will be redelivered by their broker. |true
`maxPendingChunkedMessage`|int| The maximum size of a queue holding pending chunked messages. When the threshold is reached, the consumer drops pending messages to optimize memory utilization.|10
`expireTimeOfIncompleteChunkedMessageMillis`|long|The time interval to expire incomplete chunks if a consumer fails to receive all the chunks in the specified time period. The default value is 1 minute. | 60000
-`ackReceiptEnabled`|boolean| If `ackReceiptEnabled` is enabled, ACK returns a receipt. The message is resent after getting the receipt.
+`ackReceiptEnabled`|boolean| If `ackReceiptEnabled` is enabled, ACK returns a receipt. The message may still be resent after getting the receipt. | false
Review Comment:
Thanks, I update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #16923: [fix][doc] fix `ackReceiptEnabled` doc
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #16923:
URL: https://github.com/apache/pulsar/pull/16923#issuecomment-1206105021
@michaeljmarshall @lhotari PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #16923: [fix][doc] fix `ackReceiptEnabled` doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16923:
URL: https://github.com/apache/pulsar/pull/16923#issuecomment-1204960712
Thanks for your contribution! LGTM from the technical writing perspective 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16923: [fix][doc] fix `ackReceiptEnabled` doc
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on code in PR #16923:
URL: https://github.com/apache/pulsar/pull/16923#discussion_r940050258
##########
site2/docs/client-libraries-java.md:
##########
@@ -744,7 +744,7 @@ When you create a consumer, you can use the `loadConf` configuration. The follow
`autoAckOldestChunkedMessageOnQueueFull`|boolean|Whether to automatically acknowledge pending chunked messages when the threashold of `maxPendingChunkedMessage` is reached. If set to `false`, these messages will be redelivered by their broker. |true
`maxPendingChunkedMessage`|int| The maximum size of a queue holding pending chunked messages. When the threshold is reached, the consumer drops pending messages to optimize memory utilization.|10
`expireTimeOfIncompleteChunkedMessageMillis`|long|The time interval to expire incomplete chunks if a consumer fails to receive all the chunks in the specified time period. The default value is 1 minute. | 60000
-`ackReceiptEnabled`|boolean| If `ackReceiptEnabled` is enabled, ACK returns a receipt. The message is resent after getting the receipt.
+`ackReceiptEnabled`|boolean| If `ackReceiptEnabled` is enabled, ACK returns a receipt. The message may still be resent after getting the receipt. | false
Review Comment:
```suggestion
`ackReceiptEnabled`|boolean| If `ackReceiptEnabled` is enabled, ACK returns a receipt. The client got the ack receipt means the broker has processed the ack request, but if without transaction, the broker does not guarantee persistence of acknowledgments, which means the messages still have a chance to be redelivered after the broker crashes. With the transaction, the client can only get the receipt after the acknowledgments have been persistent. | false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #16923: [fix][doc] fix `ackReceiptEnabled` doc
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16923:
URL: https://github.com/apache/pulsar/pull/16923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org