You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/06 23:27:15 UTC

[GitHub] [beam] robertwb commented on a diff in pull request #22982: [BEAM-22856] PythonService Beam version compatibility

robertwb commented on code in PR #22982:
URL: https://github.com/apache/beam/pull/22982#discussion_r964253260


##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonService.java:
##########
@@ -132,6 +136,17 @@ private String whichPython() {
     throw new RuntimeException("Unable to find a suitable Python executable.");
   }
 
+  @VisibleForTesting
+  static String getMatchingStablePythonSDKVersion(String javaSDKVersion) {
+    if (javaSDKVersion == null) {

Review Comment:
   I'm curious when this can happen.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org