You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by us...@apache.org on 2018/10/18 10:36:33 UTC

lucene-solr:master: LUCENE-8533: Fix Javadocs of DataInput#readVInt(): Negative numbers are supported, but should be avoided.

Repository: lucene-solr
Updated Branches:
  refs/heads/master e6f6f352c -> 167c65afa


LUCENE-8533: Fix Javadocs of DataInput#readVInt(): Negative numbers are supported, but should be avoided.


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/167c65af
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/167c65af
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/167c65af

Branch: refs/heads/master
Commit: 167c65afadc164beb870337a1076ef146387b55d
Parents: e6f6f35
Author: Uwe Schindler <us...@apache.org>
Authored: Thu Oct 18 12:36:16 2018 +0200
Committer: Uwe Schindler <us...@apache.org>
Committed: Thu Oct 18 12:36:16 2018 +0200

----------------------------------------------------------------------
 lucene/CHANGES.txt                                          | 3 +++
 lucene/core/src/java/org/apache/lucene/store/DataInput.java | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/167c65af/lucene/CHANGES.txt
----------------------------------------------------------------------
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 7a181bd..50b1cf3 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -208,6 +208,9 @@ Other:
 * LUCENE-8523: Correct typo in JapaneseNumberFilterFactory javadocs (Ankush Jhalani
   via Alan Woodward)
 
+* LUCENE-8533: Fix Javadocs of DataInput#readVInt(): Negative numbers are
+  supported, but should be avoided. (Vladimir Dolzhenko via Uwe Schindler)
+
 ======================= Lucene 7.5.1 =======================
 
 Bug Fixes:

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/167c65af/lucene/core/src/java/org/apache/lucene/store/DataInput.java
----------------------------------------------------------------------
diff --git a/lucene/core/src/java/org/apache/lucene/store/DataInput.java b/lucene/core/src/java/org/apache/lucene/store/DataInput.java
index d834995..2514b84 100644
--- a/lucene/core/src/java/org/apache/lucene/store/DataInput.java
+++ b/lucene/core/src/java/org/apache/lucene/store/DataInput.java
@@ -103,8 +103,8 @@ public abstract class DataInput implements Cloneable {
   }
 
   /** Reads an int stored in variable-length format.  Reads between one and
-   * five bytes.  Smaller values take fewer bytes.  Negative numbers are not
-   * supported.
+   * five bytes.  Smaller values take fewer bytes.  Negative numbers are
+   * supported, but should be avoided.
    * <p>
    * The format is described further in {@link DataOutput#writeVInt(int)}.
    *