[GitHub] [lucene] jpountz commented on a diff in pull request #12366: Move TermAndBoost back to its original location.

["jpountz (via GitHub)" <gi...@apache.org>]

jpountz commented on code in PR #12366:
URL: https://github.com/apache/lucene/pull/12366#discussion_r1228628622


##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/word2vec/TermAndBoost.java:
##########
@@ -14,7 +14,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.lucene.util;
+package org.apache.lucene.analysis.synonym.word2vec;
+
+import org.apache.lucene.util.BytesRef;

Review Comment:
   Good call on reducing visibility. I tried to see if private worked and it did not, but I forgot to check if pkg-private would work, it does!
   
   I think it's fine to use the same name, at least I don't want to give it a weird name for the sake of having a different name? E.g. we have lots of `ScoreAndDoc` classes across many packages and it's fine?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org