You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:59:19 UTC
[GitHub] [arrow-datafusion] houqp opened a new pull request #548: reuse code for now function expr creation
houqp opened a new pull request #548:
URL: https://github.com/apache/arrow-datafusion/pull/548
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Move self contained change from #55 to separate PR to help reduce code review load.
# What changes are included in this PR?
Reuse code for now function expr creation and fix TODO item in code.
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #548: reuse code for now function expr creation
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #548:
URL: https://github.com/apache/arrow-datafusion/pull/548#discussion_r650450644
##########
File path: datafusion/src/physical_plan/functions.rs
##########
@@ -579,55 +575,47 @@ pub fn create_physical_expr(
"Unsupported data type {:?} for function btrim",
other,
))),
- },
- BuiltinScalarFunction::CharacterLength => |args| match args[0].data_type() {
- DataType::Utf8 => {
- let func = invoke_if_unicode_expressions_feature_flag!(
- character_length,
- Int32Type,
- "character_length"
- );
- make_scalar_function(func)(args)
- }
- DataType::LargeUtf8 => {
- let func = invoke_if_unicode_expressions_feature_flag!(
- character_length,
- Int64Type,
- "character_length"
- );
- make_scalar_function(func)(args)
- }
- other => Err(DataFusionError::Internal(format!(
- "Unsupported data type {:?} for function character_length",
- other,
- ))),
- },
+ }),
+ BuiltinScalarFunction::CharacterLength => {
+ Arc::new(|args| match args[0].data_type() {
+ DataType::Utf8 => {
+ let func = invoke_if_unicode_expressions_feature_flag!(
+ character_length,
+ Int32Type,
+ "character_length"
+ );
+ make_scalar_function(func)(args)
+ }
+ DataType::LargeUtf8 => {
+ let func = invoke_if_unicode_expressions_feature_flag!(
+ character_length,
+ Int64Type,
+ "character_length"
+ );
+ make_scalar_function(func)(args)
+ }
+ other => Err(DataFusionError::Internal(format!(
+ "Unsupported data type {:?} for function character_length",
+ other,
+ ))),
+ })
+ }
BuiltinScalarFunction::Chr => {
- |args| make_scalar_function(string_expressions::chr)(args)
+ Arc::new(|args| make_scalar_function(string_expressions::chr)(args))
}
- BuiltinScalarFunction::Concat => string_expressions::concat,
+ BuiltinScalarFunction::Concat => Arc::new(string_expressions::concat),
BuiltinScalarFunction::ConcatWithSeparator => {
- |args| make_scalar_function(string_expressions::concat_ws)(args)
+ Arc::new(|args| make_scalar_function(string_expressions::concat_ws)(args))
}
- BuiltinScalarFunction::DatePart => datetime_expressions::date_part,
- BuiltinScalarFunction::DateTrunc => datetime_expressions::date_trunc,
+ BuiltinScalarFunction::DatePart => Arc::new(datetime_expressions::date_part),
+ BuiltinScalarFunction::DateTrunc => Arc::new(datetime_expressions::date_trunc),
BuiltinScalarFunction::Now => {
// bind value for now at plan time
- let fun_expr = Arc::new(datetime_expressions::make_now(
+ Arc::new(datetime_expressions::make_now(
ctx_state.execution_props.query_execution_start_time,
- ));
-
- // TODO refactor code to not return here, but instead fall through below
Review comment:
This is the TODO item that gets addressed in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #548: reuse code for now function expr creation
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #548:
URL: https://github.com/apache/arrow-datafusion/pull/548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #548: reuse code for now function expr creation
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #548:
URL: https://github.com/apache/arrow-datafusion/pull/548#issuecomment-860131843
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#548](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5083dfe) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/d3828541a61b5681b93590a47e22d63715949136?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d382854) will **decrease** coverage by `0.00%`.
> The diff coverage is `73.33%`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
- Coverage 76.09% 76.08% -0.01%
==========================================
Files 156 156
Lines 27047 27040 -7
==========================================
- Hits 20581 20574 -7
Misses 6466 6466
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/src/physical\_plan/functions.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/548/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvcGh5c2ljYWxfcGxhbi9mdW5jdGlvbnMucnM=) | `92.66% <73.33%> (-0.04%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d382854...5083dfe](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #548: reuse code for now function expr creation
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #548:
URL: https://github.com/apache/arrow-datafusion/pull/548#issuecomment-860131843
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#548](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b38ef9a) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/8f4078d83f7ea0348fa43906d26156bf8a95de4c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f4078d) will **decrease** coverage by `0.00%`.
> The diff coverage is `73.33%`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
- Coverage 76.09% 76.08% -0.01%
==========================================
Files 156 156
Lines 27048 27041 -7
==========================================
- Hits 20581 20574 -7
Misses 6467 6467
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/src/physical\_plan/functions.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/548/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvcGh5c2ljYWxfcGxhbi9mdW5jdGlvbnMucnM=) | `92.66% <73.33%> (-0.04%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8f4078d...b38ef9a](https://codecov.io/gh/apache/arrow-datafusion/pull/548?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org