You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/09/23 06:41:47 UTC
[GitHub] [thrift] Jimexist opened a new pull request, #2671: [build infra] disable opam sandboxing for ubuntu focal
Jimexist opened a new pull request, #2671:
URL: https://github.com/apache/thrift/pull/2671
<!-- Explain the changes in the pull request below: -->
disable opam sandboxing for ubuntu focal, in order to fix error message https://app.travis-ci.com/github/apache/thrift/jobs/583252815
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on pull request #2671: [build infra][ocaml] disable opam sandboxing for ubuntu bionic and focal
Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2671:
URL: https://github.com/apache/thrift/pull/2671#issuecomment-1256821925
i'm merging this in hope for fixing ocaml broken build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist merged pull request #2671: [build infra][ocaml] disable opam sandboxing for ubuntu bionic and focal
Posted by GitBox <gi...@apache.org>.
Jimexist merged PR #2671:
URL: https://github.com/apache/thrift/pull/2671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on pull request #2671: disable opam sandboxing for ubuntu focal
Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2671:
URL: https://github.com/apache/thrift/pull/2671#issuecomment-1253170187
i see that [this build][1] went through successfully, so maybe this error is transient and thus requires no fix
[1]: https://app.travis-ci.com/github/apache/thrift/builds/255796476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist closed pull request #2671: [build infra] disable opam sandboxing for ubuntu focal
Posted by GitBox <gi...@apache.org>.
Jimexist closed pull request #2671: [build infra] disable opam sandboxing for ubuntu focal
URL: https://github.com/apache/thrift/pull/2671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on a diff in pull request #2671: disable opam sandboxing for ubuntu focal
Posted by GitBox <gi...@apache.org>.
Jimexist commented on code in PR #2671:
URL: https://github.com/apache/thrift/pull/2671#discussion_r976000580
##########
build/docker/ubuntu-focal/Dockerfile:
##########
@@ -197,7 +197,8 @@ RUN apt-get install -y --no-install-recommends \
`# OCaml dependencies` \
ocaml \
opam && \
- opam init --yes && \
+ `# disable sandboxing see https://github.com/ocaml/opam/issues/4327` \
Review Comment:
```suggestion
`# Disable sandboxing given already in container, see https://github.com/ocaml/opam/issues/4327` \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on pull request #2671: [build infra][ocaml] disable opam sandboxing for ubuntu focal
Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2671:
URL: https://github.com/apache/thrift/pull/2671#issuecomment-1255900552
Hi @Jens-G I'm trying to resolve the `opam` error by disabling sandboxing which isn't needed given it's already run within a docker image.
this will expose other failures in swift but it can be fixed in a subsequent PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org