You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Chunhui Shi (JIRA)" <ji...@apache.org> on 2017/02/21 20:50:44 UTC
[jira] [Commented] (DRILL-5286) When rel and target candidate set
is the same, planner should not need to do convert for the relNode since it
must have been done
[ https://issues.apache.org/jira/browse/DRILL-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876690#comment-15876690 ]
Chunhui Shi commented on DRILL-5286:
------------------------------------
In SubsetTransformer.go
<code>
for (RelNode rel : ((RelSubset)candidateSet).getRelList()) {
if (isPhysical(rel)) {
RelNode newRel = RelOptRule.convert(candidateSet, rel.getTraitSet().plus(Prel.DRILL_PHYSICAL));
RelNode out = convertChild(n, newRel);
....
</code>
We should not need to do convertChild again if the newRel is the same as one already run before.
> When rel and target candidate set is the same, planner should not need to do convert for the relNode since it must have been done
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: DRILL-5286
> URL: https://issues.apache.org/jira/browse/DRILL-5286
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Chunhui Shi
> Assignee: Chunhui Shi
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)