You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Colin Ma <ju...@intel.com> on 2015/11/16 08:31:38 UTC

Review Request 40338: SQOOP-2680: Sqoop2: Remove the id from public interface for connection

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40338/
-----------------------------------------------------------

Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

Remove the id from public interface for connection


Diffs
-----

  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java ef898db 
  server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java 864b0be 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 2f6edc1 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java f72f0eb 
  test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java d083d37 

Diff: https://reviews.apache.org/r/40338/diff/


Testing
-------


Thanks,

Colin Ma


Re: Review Request 40338: SQOOP-2680: Sqoop2: Remove the id from public interface for connection

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40338/#review106889
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Nov. 16, 2015, 11:36 a.m., Colin Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40338/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 11:36 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Remove the id from public interface for connection
> 
> 
> Diffs
> -----
> 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java ef898db 
>   server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java 864b0be 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 2f6edc1 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java f72f0eb 
>   test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java d083d37 
> 
> Diff: https://reviews.apache.org/r/40338/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Ma
> 
>


Re: Review Request 40338: SQOOP-2680: Sqoop2: Remove the id from public interface for connection

Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40338/
-----------------------------------------------------------

(Updated Nov. 16, 2015, 11:36 a.m.)


Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

Remove the id from public interface for connection


Diffs (updated)
-----

  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java ef898db 
  server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java 864b0be 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 2f6edc1 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java f72f0eb 
  test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java d083d37 

Diff: https://reviews.apache.org/r/40338/diff/


Testing
-------


Thanks,

Colin Ma