You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/11/24 01:52:59 UTC

[PR] [SPARK-46083][PYTHON] Make SparkNoSuchElementException as a canonical error API [spark]

HyukjinKwon opened a new pull request, #43992:
URL: https://github.com/apache/spark/pull/43992

   ### What changes were proposed in this pull request?
   
   This PR is a kind of a followup of https://github.com/apache/spark/pull/43927 which added `SparkNoSuchElementException` into errors. This PR makes `SparkNoSuchElementException` as a canonical error API.
   
   ### Why are the changes needed?
   
   For the end users to catch those exceptions properly via `pyspark.errors.SparkNoSuchElementException` with/without Spark Connect.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, it adds a new API `SparkNoSuchElementException` class.
   
   ### How was this patch tested?
   
   Manually tested:
   
   ```bash
   ./bin/pyspark
   ```
   
   ```bash
   ./bin/pyspark --remote local
   ```
   
   ```python
   from pyspark.errors import SparkNoSuchElementException
   
   try:
       spark.conf.get("my_key")
   except SparkNoSuchElementException as e:
       print("caught properly")
   ```
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46083][PYTHON] Make SparkNoSuchElementException as a canonical error API [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43992:
URL: https://github.com/apache/spark/pull/43992#issuecomment-1825187064

   All tests passed. Merged to master for Apache Spark 4.0.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46083][PYTHON] Make SparkNoSuchElementException as a canonical error API [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43992: [SPARK-46083][PYTHON] Make SparkNoSuchElementException as a canonical error API
URL: https://github.com/apache/spark/pull/43992


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46083][PYTHON] Make SparkNoSuchElementException as a canonical error API [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43992:
URL: https://github.com/apache/spark/pull/43992#issuecomment-1825057800

   cc @itholic 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46083][PYTHON] Make SparkNoSuchElementException as a canonical error API [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43992:
URL: https://github.com/apache/spark/pull/43992#issuecomment-1825058902

   Build: https://github.com/HyukjinKwon/spark/actions/runs/6975938047
   
   Thank you @dongjoon-hyun !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org