You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2023/01/11 11:32:41 UTC
[GitHub] [avro] clesaec opened a new pull request, #2053: AVRO-3704: namae validator interface
clesaec opened a new pull request, #2053:
URL: https://github.com/apache/avro/pull/2053
<!--
*Thank you very much for contributing to Apache Avro - we are happy that you want to help us improve Avro. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Avro a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/AVRO/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "AVRO-XXXX: [component] Title of the pull request", where *AVRO-XXXX* should be replaced by the actual issue number.
The *component* is optional, but can help identify the correct reviewers faster: either the language ("java", "python") or subsystem such as "build" or "doc" are good candidates.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests. You can [build the entire project](https://github.com/apache/avro/blob/master/BUILD.md) or just the [language-specific SDK](https://avro.apache.org/project/how-to-contribute/#unit-tests).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Every commit message references Jira issues in their subject lines. In addition, commits follow the guidelines from [How to write a good git commit message](https://chris.beams.io/posts/git-commit/)
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
-->
## What is the purpose of the change
As explain in [AVRO-3704](https://issues.apache.org/jira/browse/AVRO-3704), this is to allow, in Java, to choose name validation type. Currently, there is only a choice between no validation at all or a validation that accept accent, which is not accepted by official doc.
Here, we allow user to inject its own interface of name validation ; and, in same time, proposed 3 kind of implementation :
- No validation : accept all names, like currently when option "no validation" is chosen.
- Utf validation : reproduce current java code and accept accent.
- Strict validation : follow documentation.
## Verifying this change
This change added tests and can be verified as follows:
Unit test SchemaNameValidatorTest is added and can be run locally (like it is run in CI)
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? not documented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] knotenpunkt commented on pull request #2053: AVRO-3704: name validator interface
Posted by "knotenpunkt (via GitHub)" <gi...@apache.org>.
knotenpunkt commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1446539512
This naming-thing was also a problem, if we use that avro-lib in combination with parquet. It is an nice adapter, but that validating of the names entailed that we can't write parquet files with "all" names, also at reading-parquets file in with that library caused in exceptions
Take a look here: https://stackoverflow.com/a/39734610/2182302
```java
try (ParquetWriter<GenericData.Record> writer = AvroParquetWriter
.<GenericData.Record>builder(fileToWrite)
.withSchema(schema)
.withConf(new Configuration())
.withCompressionCodec(CompressionCodecName.SNAPPY)
.build()) {
for (GenericData.Record record : recordsToWrite) {
writer.write(record);
}
}
```
I think a lot of projects use that AvroParquetWriter
**Maybe we should deactivate that naming-validation in that `AvroParquetWriter` by default?**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec commented on pull request #2053: AVRO-3704: name validator interface
Posted by "clesaec (via GitHub)" <gi...@apache.org>.
clesaec commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1450339603
Store in **static** to be accessible from anywhere without modifying code.
In **thread local** to allow several thread to work with different name validator (may be InheritableThreadLocal would be even better ?).
For **volatile**, as an instance of name validator has no state, there are no reason to declare it volatile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec commented on pull request #2053: AVRO-3704: name validator interface
Posted by "clesaec (via GitHub)" <gi...@apache.org>.
clesaec commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1522839080
No, this add possibilities but this is fully compatible with current master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec commented on pull request #2053: AVRO-3704: name validator interface
Posted by "clesaec (via GitHub)" <gi...@apache.org>.
clesaec commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1449529672
Indeed, I had not taken into account SchemaBuilder (only Schema parser).
So, i know put a public setter on static threadlocal Schema NameValidator; so, you can use `Schema.setNameValidator(Schema.NameValidator.NO_VALIDATION);`
(_May be a better solution would have to add a method "SchemaBuilder.builder(NameValidator v)" and then use it, but it would also imply a lot of change (in class Name, ...) for only one PR_)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec commented on a diff in pull request #2053: AVRO-3704: namae validator interface
Posted by GitBox <gi...@apache.org>.
clesaec commented on code in PR #2053:
URL: https://github.com/apache/avro/pull/2053#discussion_r1070917557
##########
pom.xml:
##########
@@ -153,6 +154,11 @@
<artifactId>apache-rat-plugin</artifactId>
<version>${apache-rat-plugin.version}</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <version>${maven-resources-plugin.version}</version>
+ </plugin>
Review Comment:
The CI failed at "maven4" step, see last comment on [AVRO-3701](https://issues.apache.org/jira/browse/AVRO-3701), i put this plugin from 1.7.0 to 3.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec commented on pull request #2053: AVRO-3704: name validator interface
Posted by "clesaec (via GitHub)" <gi...@apache.org>.
clesaec commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1587179774
@RyanSkraba : WDYT about this PR for Avro naming ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] knotenpunkt commented on pull request #2053: AVRO-3704: name validator interface
Posted by "knotenpunkt (via GitHub)" <gi...@apache.org>.
knotenpunkt commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1522141178
are there any updates, when this comes into the master?^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #2053: AVRO-3704: name validator interface
Posted by "RyanSkraba (via GitHub)" <gi...@apache.org>.
RyanSkraba commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1591590287
Hey -- this is on my radar! I should have a bit more time once the release 1.11.2 candidate is (finally) done. Thanks for your patience...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on a diff in pull request #2053: AVRO-3704: namae validator interface
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #2053:
URL: https://github.com/apache/avro/pull/2053#discussion_r1091836429
##########
pom.xml:
##########
@@ -153,6 +154,11 @@
<artifactId>apache-rat-plugin</artifactId>
<version>${apache-rat-plugin.version}</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <version>${maven-resources-plugin.version}</version>
+ </plugin>
Review Comment:
https://github.com/apache/avro/pull/2075 - I've extracted just this change, so that all other PRs won't break because of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] opwvhk commented on pull request #2053: AVRO-3704: namae validator interface
Posted by "opwvhk (via GitHub)" <gi...@apache.org>.
opwvhk commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1410242292
> I would adapt it if yours is merge before :)
Ah, if only... but it also required the ANTLR PRs (#1588 and #1589) to be merged, and there simple haven't been enough reviews yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] knotenpunkt commented on pull request #2053: AVRO-3704: name validator interface
Posted by "knotenpunkt (via GitHub)" <gi...@apache.org>.
knotenpunkt commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1446567484
> As explain in [AVRO-3704](https://issues.apache.org/jira/browse/AVRO-3704), this is to allow, in Java, to choose name validation type. Currently, there is only a choice between **no validation at all** or a validation that accept accent, which is not accepted by official doc.
How was it possible to choose no validation at all, if i use `AvroParquetWriter` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] knotenpunkt commented on pull request #2053: AVRO-3704: name validator interface
Posted by "knotenpunkt (via GitHub)" <gi...@apache.org>.
knotenpunkt commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1450291411
> Indeed, I had not taken into account SchemaBuilder (only Schema parser).
> So, i know put a public setter on static threadlocal Schema NameValidator; so, you can use `Schema.setNameValidator(Schema.NameValidator.NO_VALIDATION);`
> (_May be a better solution would have to add a method "SchemaBuilder.builder(NameValidator v)" and then use it, but it would also imply a lot of change (in class Name, ...) for only one PR_)
yeah your last commit [AVRO-3704: add setter to static name validator](https://github.com/apache/avro/pull/2053/commits/c60a5dc58d2c6571ed7fcfd5a66165947f4b4b6b) should do the trick. So but i think we must wait until this pr is merged? What do you think when it would happen?
And you are right, a solution by injecting the validation rule into the builder direclty would be nicer, but doing this over that static method is also ok.
May i ask one other question: Why do you store that validation rule in an Threadlocal and not just in a (volatile or normal) variable? -> performance reasons?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] github-code-scanning[bot] commented on a diff in pull request #2053: AVRO-3704: namae validator interface
Posted by GitBox <gi...@apache.org>.
github-code-scanning[bot] commented on code in PR #2053:
URL: https://github.com/apache/avro/pull/2053#discussion_r1066895474
##########
lang/java/avro/src/test/java/org/apache/avro/SchemaNameValidatorTest.java:
##########
@@ -0,0 +1,42 @@
+package org.apache.avro;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
+
+import java.util.stream.Stream;
+
+class SchemaNameValidatorTest {
Review Comment:
## Unused classes and interfaces
Unused class: SchemaNameValidatorTest is not referenced within this codebase. If not used as an external API it should be removed.
[Show more details](https://github.com/apache/avro/security/code-scanning/2964)
##########
lang/java/avro/src/main/java/org/apache/avro/Schema.java:
##########
@@ -1724,7 +1712,7 @@
if (defaultValue != null
&& (Type.FLOAT.equals(fieldSchema.getType()) || Type.DOUBLE.equals(fieldSchema.getType()))
&& defaultValue.isTextual())
- defaultValue = new DoubleNode(Double.valueOf(defaultValue.textValue()));
+ defaultValue = new DoubleNode(Double.parseDouble(defaultValue.textValue()));
Review Comment:
## Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more details](https://github.com/apache/avro/security/code-scanning/2965)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec commented on pull request #2053: AVRO-3704: namae validator interface
Posted by GitBox <gi...@apache.org>.
clesaec commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1385418428
NameValidator has no direct link with Schema nor SchemaParser; so it could be easily embeded in SchemaParser or put in a separate Java file with your PR (i didn't figure out yet what would be the best).
And i agree with you, even if Schema.java is divided into several small independant pieces (classes), i also would prefer to see SchemaParser in a separate file (and mostly put [Schema.parse(JsonNodes, Names) method outside](https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/Schema.java#L1672) of Schema class).
I also made this small [PR](https://github.com/apache/avro/pull/1768) on schema parsing that allow to load recursive protocol like
```json
{"name": "User", "type": "record", "fields": [{"name": "current_status", "type": "Status"}]}
{"name": "Status", "type": "record", "fields": [{"name": "author", "type": "User"}]}
```
I would adapt it if yours is merge before :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] knotenpunkt commented on pull request #2053: AVRO-3704: name validator interface
Posted by "knotenpunkt (via GitHub)" <gi...@apache.org>.
knotenpunkt commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1446543289
Actually we used that library by patching that avro-schema-java-file with some maven magic:
```java
private static String validateName(String name) {
// if (!validateNames.get())
// return name; // not validating names
// if (name == null)
// throw new SchemaParseException("Null name");
// int length = name.length();
// if (length == 0)
// throw new SchemaParseException("Empty name");
// char first = name.charAt(0);
// if (!(Character.isLetter(first) || first == '_'))
// throw new SchemaParseException("Illegal initial character: " + name);
// for (int i = 1; i < length; i++) {
// char c = name.charAt(i);
// if (!(Character.isLetterOrDigit(c) || c == '_'))
// throw new SchemaParseException("Illegal character in: " + name);
// }
return name;
}
```
This pull-request can solve that, so we don't have to trick like that any more?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec commented on pull request #2053: AVRO-3704: name validator interface
Posted by "clesaec (via GitHub)" <gi...@apache.org>.
clesaec commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1446599497
As NameValidator is an interface, in fact, you can also put your own customize name validator.
For AvroParquetWriter, it seems to take directly an Avro Schema, and as name validation is only called on Schema construction, it should be OK. I don't have example to give as [AvroParquetWriter is owned by parquet github project](https://github.com/apache/parquet-mr/blob/master/parquet-avro/src/main/java/org/apache/parquet/avro/AvroParquetWriter.java).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] knotenpunkt commented on pull request #2053: AVRO-3704: name validator interface
Posted by "knotenpunkt (via GitHub)" <gi...@apache.org>.
knotenpunkt commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1527980632
@clesaec are you sure?
this one isnt in the master, so i cant change it or deactivate the nameValidator:
https://github.com/apache/avro/pull/2053/commits/c60a5dc58d2c6571ed7fcfd5a66165947f4b4b6b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] opwvhk commented on a diff in pull request #2053: AVRO-3704: namae validator interface
Posted by GitBox <gi...@apache.org>.
opwvhk commented on code in PR #2053:
URL: https://github.com/apache/avro/pull/2053#discussion_r1069564268
##########
pom.xml:
##########
@@ -153,6 +154,11 @@
<artifactId>apache-rat-plugin</artifactId>
<version>${apache-rat-plugin.version}</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <version>${maven-resources-plugin.version}</version>
+ </plugin>
Review Comment:
I don't understand this addition: why was the `maven-resources-plugin` added? Was it to be able to specify a recent version number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] knotenpunkt commented on pull request #2053: AVRO-3704: name validator interface
Posted by "knotenpunkt (via GitHub)" <gi...@apache.org>.
knotenpunkt commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1448413036
> As NameValidator is an interface, in fact, you can also put your own customize name validator. For AvroParquetWriter, it seems to take directly an Avro Schema, and as name validation is only called on Schema construction, it should be OK. I don't have example to give as [AvroParquetWriter is owned by parquet github project](https://github.com/apache/parquet-mr/blob/master/parquet-avro/src/main/java/org/apache/parquet/avro/AvroParquetWriter.java).
Yes you are right, it takes a normal AvroSchema directly.
We build that Schema from that SchemaBuilder (this repository^^)
But how can i set in that Builder my own customize name validator or how can i disable it at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on a diff in pull request #2053: AVRO-3704: namae validator interface
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #2053:
URL: https://github.com/apache/avro/pull/2053#discussion_r1091954876
##########
pom.xml:
##########
@@ -153,6 +154,11 @@
<artifactId>apache-rat-plugin</artifactId>
<version>${apache-rat-plugin.version}</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <version>${maven-resources-plugin.version}</version>
+ </plugin>
Review Comment:
It still fails so I created https://issues.apache.org/jira/browse/MRRESOURCES-124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec merged pull request #2053: AVRO-3704: name validator interface
Posted by "clesaec (via GitHub)" <gi...@apache.org>.
clesaec merged PR #2053:
URL: https://github.com/apache/avro/pull/2053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec commented on pull request #2053: AVRO-3704: name validator interface
Posted by "clesaec (via GitHub)" <gi...@apache.org>.
clesaec commented on PR #2053:
URL: https://github.com/apache/avro/pull/2053#issuecomment-1530941220
I meant that as by default, [default new validator](https://github.com/apache/avro/blob/c60a5dc58d2c6571ed7fcfd5a66165947f4b4b6b/lang/java/avro/src/main/java/org/apache/avro/Schema.java#L1589) behave like current validation, the merge of this PR in master won't modify current behavior.
setNameValidator is indeed a new method in this PR, allow you to update validation method.
Is that answer your question ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org