You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/30 19:42:41 UTC
[GitHub] [pulsar] dave2wave opened a new pull request #11844: [Website] Remove Company Logos From Main Page
dave2wave opened a new pull request #11844:
URL: https://github.com/apache/pulsar/pull/11844
### Motivation
Align the Pulsar Website Main Page with Apache Software Foundation Policy.
### Modifications
Remove company logos and renamed the link to the powered by page.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [ ] doc-required
- [ ] no-need-doc
- [ ] doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #11844: [Website] Remove Company Logos From Main Page
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #11844:
URL: https://github.com/apache/pulsar/pull/11844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #11844: [Website] Remove Company Logos From Main Page
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #11844:
URL: https://github.com/apache/pulsar/pull/11844#discussion_r698799705
##########
File path: site2/website/pages/en/index.js
##########
@@ -168,30 +168,7 @@ const UsersBlock = props => (
id={props.id}
background={props.background}>
- <p align="center"><small style={{color: 'black', fontSize: '1.7rem'}}>Used by companies such as</small></p>
- <div class="logo-wrapper">
- {
- featuredUsers.map(
- c => (
- (() => {
- if (c.hasOwnProperty('logo_white')) {
- return <div className="logo-box-background-for-white">
- <a href={c.url} title={c.name} target="_blank">
- <img src={c.logo} alt={c.name} className={c.logo.endsWith('.svg') ? 'logo-svg' : ''}/>
- </a>
- </div>
- } else {
- return <div className="logo-box">
- <a href={c.url} title={c.name} target="_blank">
- <img src={c.logo} alt={c.name} className={c.logo.endsWith('.svg') ? 'logo-svg' : ''}/>
- </a>
- </div>
- }
- })()
- )
- )}
- </div>
- <p align="center"><small style={{color: 'black', fontSize: '1.7rem'}}><a href="/powered-by">... and many more</a></small></p>
+ <p align="center"><small style={{color: 'black', fontSize: '1.7rem'}}><a href="/powered-by">Used by companies such as ...</a></small></p>
Review comment:
@dave2wave @eolivelli The text will now look incomplete with the dots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #11844: [Website] Remove Company Logos From Main Page
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #11844:
URL: https://github.com/apache/pulsar/pull/11844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #11844: [Website] Remove Company Logos From Main Page
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #11844:
URL: https://github.com/apache/pulsar/pull/11844#discussion_r698799705
##########
File path: site2/website/pages/en/index.js
##########
@@ -168,30 +168,7 @@ const UsersBlock = props => (
id={props.id}
background={props.background}>
- <p align="center"><small style={{color: 'black', fontSize: '1.7rem'}}>Used by companies such as</small></p>
- <div class="logo-wrapper">
- {
- featuredUsers.map(
- c => (
- (() => {
- if (c.hasOwnProperty('logo_white')) {
- return <div className="logo-box-background-for-white">
- <a href={c.url} title={c.name} target="_blank">
- <img src={c.logo} alt={c.name} className={c.logo.endsWith('.svg') ? 'logo-svg' : ''}/>
- </a>
- </div>
- } else {
- return <div className="logo-box">
- <a href={c.url} title={c.name} target="_blank">
- <img src={c.logo} alt={c.name} className={c.logo.endsWith('.svg') ? 'logo-svg' : ''}/>
- </a>
- </div>
- }
- })()
- )
- )}
- </div>
- <p align="center"><small style={{color: 'black', fontSize: '1.7rem'}}><a href="/powered-by">... and many more</a></small></p>
+ <p align="center"><small style={{color: 'black', fontSize: '1.7rem'}}><a href="/powered-by">Used by companies such as ...</a></small></p>
Review comment:
@dave2wave @eolivelli The text will now look incomplete with the dots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on a change in pull request #11844: [Website] Remove Company Logos From Main Page
Posted by GitBox <gi...@apache.org>.
dave2wave commented on a change in pull request #11844:
URL: https://github.com/apache/pulsar/pull/11844#discussion_r698815597
##########
File path: site2/website/pages/en/index.js
##########
@@ -168,30 +168,7 @@ const UsersBlock = props => (
id={props.id}
background={props.background}>
- <p align="center"><small style={{color: 'black', fontSize: '1.7rem'}}>Used by companies such as</small></p>
- <div class="logo-wrapper">
- {
- featuredUsers.map(
- c => (
- (() => {
- if (c.hasOwnProperty('logo_white')) {
- return <div className="logo-box-background-for-white">
- <a href={c.url} title={c.name} target="_blank">
- <img src={c.logo} alt={c.name} className={c.logo.endsWith('.svg') ? 'logo-svg' : ''}/>
- </a>
- </div>
- } else {
- return <div className="logo-box">
- <a href={c.url} title={c.name} target="_blank">
- <img src={c.logo} alt={c.name} className={c.logo.endsWith('.svg') ? 'logo-svg' : ''}/>
- </a>
- </div>
- }
- })()
- )
- )}
- </div>
- <p align="center"><small style={{color: 'black', fontSize: '1.7rem'}}><a href="/powered-by">... and many more</a></small></p>
+ <p align="center"><small style={{color: 'black', fontSize: '1.7rem'}}><a href="/powered-by">Used by companies such as ...</a></small></p>
Review comment:
Sure let's wordsmith:
c/Used by companies such as .../Click to see some of the Companies Powered by Pulsar/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on a change in pull request #11844: [Website] Remove Company Logos From Main Page
Posted by GitBox <gi...@apache.org>.
dave2wave commented on a change in pull request #11844:
URL: https://github.com/apache/pulsar/pull/11844#discussion_r698815597
##########
File path: site2/website/pages/en/index.js
##########
@@ -168,30 +168,7 @@ const UsersBlock = props => (
id={props.id}
background={props.background}>
- <p align="center"><small style={{color: 'black', fontSize: '1.7rem'}}>Used by companies such as</small></p>
- <div class="logo-wrapper">
- {
- featuredUsers.map(
- c => (
- (() => {
- if (c.hasOwnProperty('logo_white')) {
- return <div className="logo-box-background-for-white">
- <a href={c.url} title={c.name} target="_blank">
- <img src={c.logo} alt={c.name} className={c.logo.endsWith('.svg') ? 'logo-svg' : ''}/>
- </a>
- </div>
- } else {
- return <div className="logo-box">
- <a href={c.url} title={c.name} target="_blank">
- <img src={c.logo} alt={c.name} className={c.logo.endsWith('.svg') ? 'logo-svg' : ''}/>
- </a>
- </div>
- }
- })()
- )
- )}
- </div>
- <p align="center"><small style={{color: 'black', fontSize: '1.7rem'}}><a href="/powered-by">... and many more</a></small></p>
+ <p align="center"><small style={{color: 'black', fontSize: '1.7rem'}}><a href="/powered-by">Used by companies such as ...</a></small></p>
Review comment:
Sure let's wordsmith:
c/Used by companies such as .../Click to see some of the Companies Powered by Pulsar/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org