[jira] [Commented] (ZOOKEEPER-2045) ConnectStringParser public api didn't handle null connect string

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144102#comment-14144102 ] 

Hadoop QA commented on ZOOKEEPER-2045:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12670539/ZOOKEEPER-2045.patch
  against trunk revision 1626008.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2346//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2346//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2346//console

This message is automatically generated.

> ConnectStringParser public api didn't handle null connect string
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2045
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2045
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.0
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>            Priority: Minor
>         Attachments: ZOOKEEPER-2045.patch
>
>
> {code}
> public final class ConnectStringParser {
> ...
>    public ConnectStringParser(String connectString) {
>    ...
> {code}
> ConnectStringParser is a public api. Besides that, both ZooKeeper constructor and ZooKeeper#updateServerList used it.
> However, it doesn't handle a null connectString. It doesn't help that much to see a NPE showing up. So I add a check to the constructor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)