You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/14 03:38:48 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #24432: fix TestLocalTaskJob tests

uranusjr commented on code in PR #24432:
URL: https://github.com/apache/airflow/pull/24432#discussion_r896342960


##########
tests/jobs/test_local_task_job.py:
##########
@@ -462,7 +463,7 @@ def test_failure_callback_called_by_airflow_run_raw_process(self, monkeypatch, t
         assert len(lines) == 1  # invoke once
         assert lines[0].startswith(ti.key.primary)
         this_pid = str(os.getpid())
-        assert this_pid not in lines[0]
+        assert not lines[0].endswith(f"pid: {this_pid}")

Review Comment:
   This should probably be improved to test that the line _does_ end with something like `pid: {pid}`, but the `{pid}` part is not the current process.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org