You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/04 07:17:10 UTC

[GitHub] [apisix] Yiyiyimu edited a comment on issue #3514: Proposal: reuse test in CI for the release check

Yiyiyimu edited a comment on issue #3514:
URL: https://github.com/apache/apisix/issues/3514#issuecomment-773088893


   > Currently we create tag only after release as an archive. Maybe we should use release/xxx branch to trigger the test?
   
   Hi @spacewander If I take it right, we create tag after release, but we create branch before the release. So we could use that branch say `v2.3`. Create a PR, test if it works, then close it.
   
   > We can create the tarball with Makefile. Currently the tarball is created from VERSION=xxx make release-src.
   
   Since we could not have bot to add PR, so the tarball created by Github Actions could not be reused by us. And if I take it right, testing the tarball is to avoid problems that happens in manual tarball creation, so we need to test that **exact** tarball we're gonna release.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org