[GitHub] [camel-k] phantomjinx commented on pull request #1978: Refactors the deploy directory to make config directory single source of CRD truth

[GitBox <gi...@apache.org>]

phantomjinx commented on pull request #1978:
URL: https://github.com/apache/camel-k/pull/1978#issuecomment-771926329


   > It looks good overall, the main point is that it seems a different version of `controller-gen` is used, and produces `Any` types in the CRD schemas, which is not allowed in `apiextensions.k8s.io/v1`, and also drops some descriptions. I wonder what version of `controller-gen` is actually used? It seems to miss some of the Kubebuilder markers on the `Flow` and `JSON` types. If that's a newer version, it may be a matter of moving these annotations along the types hierarchy.
   
   It was using controller-gen 0.4.0 which I had previously compiled locally. The binary uses [runtime/debug/BuildInfo](https://golang.org/pkg/runtime/debug/#BuildInfo) to determine the version number and for local compilations this is generated as 'devel'. Wrapping the module in an outer module allows the preferred version to be printed (see [here|https://github.com/golang/go/issues/29228#issuecomment-457390055].
   
   So controller-gen version fixed, version upgraded to 0.4.1 and no more surprises in the CRDs :-)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org