You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/05/15 11:30:51 UTC

[GitHub] [zookeeper] TisonKun commented on a change in pull request #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper

TisonKun commented on a change in pull request #1095:
URL: https://github.com/apache/zookeeper/pull/1095#discussion_r425739863



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
##########
@@ -1010,11 +1002,11 @@ void primeConnection() throws IOException {
             // TODO: here we have the only remaining use of zooKeeper in
             // this class. It's to be eliminated!

Review comment:
       Exactly! I think the removal lost in the last rebase :/
   
   Updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org