You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2017/08/24 16:58:57 UTC
[Impala-ASF-CR] IMPALA-5836: Improvements to Eclipse frontend configuration.
Philip Zeyliger has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7803
Change subject: IMPALA-5836: Improvements to Eclipse frontend configuration.
......................................................................
IMPALA-5836: Improvements to Eclipse frontend configuration.
Having recently gone through setting up Eclipse for frontend debugging,
I'm amending the process a tad to make it smoother for new developers.
* Adds the JDK sources package to the developer bootstrap
process. These are useful if you need to point Eclipse to the source
of Java libraries and are harmless to everyone else.
* Defaults to "downloadSource" for the "mvn eclipse:eclipse" plugin.
This was being set explicitly in the Wiki instructions, but
there's no reason not to set it on by default for everyone.
* Adds a "launcher" file for debugging the FE. Instead of creating
a debug configuration manually, it's possible to share these across
developers by checking them in. I checked it in via a mechanism
that "mvn eclipse:eclipse" has to create additional files, to
avoid literring the directory for non-Eclipse users.
* Changes the output directory used by Eclipse's compiler to
a different one than Maven uses. Because we start Impala
from the commandline, it's easy to start Impala and then
change a line of Java, which forces Eclipse to kick in and
replace the .class files. When this happens, the existing Impala
starts complaining about class not found, because the underlying
files have been overwritten. It's preferable to separate the
directories and rely on Maven for the compiled Java.
Change-Id: Ia723fbf706cf409a8fb6b5ff0297c2b1ff7c9590
---
M bin/bootstrap_development.sh
M fe/pom.xml
2 files changed, 41 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/7803/1
--
To view, visit http://gerrit.cloudera.org:8080/7803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia723fbf706cf409a8fb6b5ff0297c2b1ff7c9590
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-5836: Improvements to Eclipse frontend configuration.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5836: Improvements to Eclipse frontend configuration.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia723fbf706cf409a8fb6b5ff0297c2b1ff7c9590
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5836: Improvements to Eclipse frontend configuration.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5836: Improvements to Eclipse frontend configuration.
......................................................................
IMPALA-5836: Improvements to Eclipse frontend configuration.
Having recently gone through setting up Eclipse for frontend debugging,
I'm amending the process a tad to make it smoother for new developers.
* Adds the JDK sources package to the developer bootstrap
process. These are useful if you need to point Eclipse to the source
of Java libraries and are harmless to everyone else.
* Defaults to "downloadSource" for the "mvn eclipse:eclipse" plugin.
This was being set explicitly in the Wiki instructions, but
there's no reason not to set it on by default for everyone.
* Adds a "launcher" file for debugging the FE. Instead of creating
a debug configuration manually, it's possible to share these across
developers by checking them in. I checked it in via a mechanism
that "mvn eclipse:eclipse" has to create additional files, to
avoid literring the directory for non-Eclipse users.
* Changes the output directory used by Eclipse's compiler to
a different one than Maven uses. Because we start Impala
from the commandline, it's easy to start Impala and then
change a line of Java, which forces Eclipse to kick in and
replace the .class files. When this happens, the existing Impala
starts complaining about class not found, because the underlying
files have been overwritten. It's preferable to separate the
directories and rely on Maven for the compiled Java.
Change-Id: Ia723fbf706cf409a8fb6b5ff0297c2b1ff7c9590
Reviewed-on: http://gerrit.cloudera.org:8080/7803
Reviewed-by: Dimitris Tsirogiannis <dt...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M bin/bootstrap_development.sh
M fe/pom.xml
2 files changed, 41 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Dimitris Tsirogiannis: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia723fbf706cf409a8fb6b5ff0297c2b1ff7c9590
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5836: Improvements to Eclipse frontend configuration.
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5836: Improvements to Eclipse frontend configuration.
......................................................................
Patch Set 1: Code-Review+2
Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/7803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia723fbf706cf409a8fb6b5ff0297c2b1ff7c9590
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5836: Improvements to Eclipse frontend configuration.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5836: Improvements to Eclipse frontend configuration.
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1151/
--
To view, visit http://gerrit.cloudera.org:8080/7803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia723fbf706cf409a8fb6b5ff0297c2b1ff7c9590
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No