You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:05:08 UTC

[GitHub] [arrow-rs] alamb commented on a diff in pull request #2816: Add string_dictionary benches for row format (#2677)

alamb commented on code in PR #2816:
URL: https://github.com/apache/arrow-rs/pull/2816#discussion_r985799903


##########
arrow/benches/row_format.rs:
##########
@@ -85,6 +88,46 @@ fn row_bench(c: &mut Criterion) {
         });
     });
 
+    let cols =

Review Comment:
   I am sorry for being dense, but I don't see any difference in the first three benchmarks. They all use
   
   ```rust
   create_string_dict_array::<Int32Type>(4096, 0., 100)
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org