You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Cassie Doll (JIRA)" <ji...@apache.org> on 2008/02/12 19:55:19 UTC
[jira] Created: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
-----------------------------------------------------------------------------------------------------------------
Key: SHINDIG-60
URL: https://issues.apache.org/jira/browse/SHINDIG-60
Project: Shindig
Issue Type: Improvement
Components: Features
Reporter: Cassie Doll
Assignee: Kevin Brown
Priority: Critical
The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SHINDIG-60) Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by Chris Chabot <ch...@xs4all.nl>.
While IANAL either, but after approximately 12 years in the open
source scene i feel like a semi qualified amateur :-)
Including the source of GPL code in your own would also make your own
code GPL. Also 'linking against it' would imply that your program is
now also subject to the GPL. The GPL does allow usage thru 'standard
interfaces' without the viral clause of it counting (think: compiling
a .c file with with gcc does not make your project GPL) but anything
that either includes it in its own source code, or links against it,
is inside of the scope of the license.
The LGPL has an exception for this (formally known as the Library-GPL
but now called the Lesser-GPL to promote the 'real deal' version of
the license), so LGPL libraries you could use in shindig (and even
include in the repo/distribution) without affecting the license of the
main code base. Any modifications done to that library would be LGPL
too, but your main code base remains as it is.
What we would be looking to use is something under the BSD/MIT/Apache
family of licenses if at all possible or otherwise with a LGPL
license, something that doesn't have the viral clause that the GPL and
relatives have.
The apache license is preferred by some companies since it is much
less restrictive then the (L)GPL & related licenses, for instance it
doesn't state that you -have- to share your modifications with anyone
(which the (L)GPL style licenses do). So this means you can keep your
work private and hidden if you want too, which is attractive to some.
-- Chris
On May 6, 2008, at 12:04 AM, John Hjelmstad wrote:
> IANAL, but my understanding is that any code that links to GPL-
> licensed code
> must be GPL-licensed as well (
> http://en.wikipedia.org/wiki/GNU_General_Public_License -
> Criticism). Can
> anyone confirm/deny in this case
Re: [jira] Commented: (SHINDIG-60) Shindig does not properly support
the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by John Hjelmstad <fa...@google.com>.
Odd that his contribution wasn't picked up by Gmail in this threadview, but
hey, fantastic! Onward...
On Mon, May 5, 2008 at 3:10 PM, Vincent Siveton <vi...@gmail.com>
wrote:
> Hi John,
>
> Agree with your thoughts but ... Gary already proposed a patch with
> Rome... Reread the thread ;)
>
> Cheers,
>
> Vincent
>
> 2008/5/5, John Hjelmstad <fa...@google.com>:
> > IANAL, but my understanding is that any code that links to GPL-licensed
> code
> > must be GPL-licensed as well (
> > http://en.wikipedia.org/wiki/GNU_General_Public_License - Criticism).
> Can
> > anyone confirm/deny in this case?
> >
> > I can't imagine we'd change Shindig's overall license, so it seems we'd
> have
> > a few options here:
> > 1. See if David Pashley would be willing to grant us an exception or
> change
> > Eddie's license. The fact that there's already a GPL exception attached
> to
> > Eddie (www.davidpashley.com/eddie.html) suggests this isn't likely to
> > happen. The existing exception allows creation of binaries linking to
> Eddie
> > irrespective their license: not exactly compatible with our goals.
> > 2. Use an alternate underlying feed parsing library such as Rome (
> > https://rome.dev.java.net/) or Apache Abdera (
> > http://incubator.apache.org/abdera/).
> >
> > Thoughts?
> >
> > John
> >
> > On Thu, Apr 24, 2008 at 12:53 AM, Milinda Lakmal Pathirage (JIRA) <
> > jira@apache.org> wrote:
> >
> > >
> > > [
> >
> > >
> https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591941#action_12591941
> ]
> > >
> > > Milinda Lakmal Pathirage commented on SHINDIG-60:
> > > -------------------------------------------------
> > >
> > > Eddie is licensed under GPL. Can Apache project use that. It may raise
> > > license problem in the future.
> > >
> > > > Shindig does not properly support the FEED content type as defined
> by the
> > > gadgets spec for gadgets.io.MakeRequest
> > > >
> > >
> -----------------------------------------------------------------------------------------------------------------
> > > >
> > > > Key: SHINDIG-60
> > > > URL:
> https://issues.apache.org/jira/browse/SHINDIG-60
> > > > Project: Shindig
> > > > Issue Type: Improvement
> > > > Components: Features (Javascript), Gadget Rendering Server
> > > (Java), Gadget Rendering Server (PHP)
> > > > Reporter: Cassie Doll
> > > > Priority: Critical
> > > > Attachments: io.js.patch, ProxyHandler.java.patch
> > > >
> > > >
> > > > The FEED contentType in gadgets.io.MakeRequest should not return
> general
> > > json in the same way that the JSON contentType does. It should instead
> > > return a structured object that looks like this:
> > > >
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
> > >
> > > --
> > > This message is automatically generated by JIRA.
> > > -
> > > You can reply to this email to add a comment to the issue online.
> > >
> > >
> >
>
Re: [jira] Commented: (SHINDIG-60) Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by Vincent Siveton <vi...@gmail.com>.
Hi John,
Agree with your thoughts but ... Gary already proposed a patch with
Rome... Reread the thread ;)
Cheers,
Vincent
2008/5/5, John Hjelmstad <fa...@google.com>:
> IANAL, but my understanding is that any code that links to GPL-licensed code
> must be GPL-licensed as well (
> http://en.wikipedia.org/wiki/GNU_General_Public_License - Criticism). Can
> anyone confirm/deny in this case?
>
> I can't imagine we'd change Shindig's overall license, so it seems we'd have
> a few options here:
> 1. See if David Pashley would be willing to grant us an exception or change
> Eddie's license. The fact that there's already a GPL exception attached to
> Eddie (www.davidpashley.com/eddie.html) suggests this isn't likely to
> happen. The existing exception allows creation of binaries linking to Eddie
> irrespective their license: not exactly compatible with our goals.
> 2. Use an alternate underlying feed parsing library such as Rome (
> https://rome.dev.java.net/) or Apache Abdera (
> http://incubator.apache.org/abdera/).
>
> Thoughts?
>
> John
>
> On Thu, Apr 24, 2008 at 12:53 AM, Milinda Lakmal Pathirage (JIRA) <
> jira@apache.org> wrote:
>
> >
> > [
>
> > https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591941#action_12591941]
> >
> > Milinda Lakmal Pathirage commented on SHINDIG-60:
> > -------------------------------------------------
> >
> > Eddie is licensed under GPL. Can Apache project use that. It may raise
> > license problem in the future.
> >
> > > Shindig does not properly support the FEED content type as defined by the
> > gadgets spec for gadgets.io.MakeRequest
> > >
> > -----------------------------------------------------------------------------------------------------------------
> > >
> > > Key: SHINDIG-60
> > > URL: https://issues.apache.org/jira/browse/SHINDIG-60
> > > Project: Shindig
> > > Issue Type: Improvement
> > > Components: Features (Javascript), Gadget Rendering Server
> > (Java), Gadget Rendering Server (PHP)
> > > Reporter: Cassie Doll
> > > Priority: Critical
> > > Attachments: io.js.patch, ProxyHandler.java.patch
> > >
> > >
> > > The FEED contentType in gadgets.io.MakeRequest should not return general
> > json in the same way that the JSON contentType does. It should instead
> > return a structured object that looks like this:
> > > http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
>
Re: [jira] Commented: (SHINDIG-60) Shindig does not properly support
the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by John Hjelmstad <fa...@google.com>.
IANAL, but my understanding is that any code that links to GPL-licensed code
must be GPL-licensed as well (
http://en.wikipedia.org/wiki/GNU_General_Public_License - Criticism). Can
anyone confirm/deny in this case?
I can't imagine we'd change Shindig's overall license, so it seems we'd have
a few options here:
1. See if David Pashley would be willing to grant us an exception or change
Eddie's license. The fact that there's already a GPL exception attached to
Eddie (www.davidpashley.com/eddie.html) suggests this isn't likely to
happen. The existing exception allows creation of binaries linking to Eddie
irrespective their license: not exactly compatible with our goals.
2. Use an alternate underlying feed parsing library such as Rome (
https://rome.dev.java.net/) or Apache Abdera (
http://incubator.apache.org/abdera/).
Thoughts?
John
On Thu, Apr 24, 2008 at 12:53 AM, Milinda Lakmal Pathirage (JIRA) <
jira@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591941#action_12591941]
>
> Milinda Lakmal Pathirage commented on SHINDIG-60:
> -------------------------------------------------
>
> Eddie is licensed under GPL. Can Apache project use that. It may raise
> license problem in the future.
>
> > Shindig does not properly support the FEED content type as defined by the
> gadgets spec for gadgets.io.MakeRequest
> >
> -----------------------------------------------------------------------------------------------------------------
> >
> > Key: SHINDIG-60
> > URL: https://issues.apache.org/jira/browse/SHINDIG-60
> > Project: Shindig
> > Issue Type: Improvement
> > Components: Features (Javascript), Gadget Rendering Server
> (Java), Gadget Rendering Server (PHP)
> > Reporter: Cassie Doll
> > Priority: Critical
> > Attachments: io.js.patch, ProxyHandler.java.patch
> >
> >
> > The FEED contentType in gadgets.io.MakeRequest should not return general
> json in the same way that the JSON contentType does. It should instead
> return a structured object that looks like this:
> > http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (SHINDIG-60) Shindig does not properly support
the FEED content type as defined by the gadgets spec for
gadgets.io.MakeRequest
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595095#action_12595095 ]
Chris Chabot commented on SHINDIG-60:
-------------------------------------
io.js.patch has been applied to the trunk.
Shindig PHP now fully supports Atom and RSS feeds through ContentType.FEED.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, fix-SHINDIG-60-bug_rome2.patch, fix-SHINDIG-60_legacy.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-60) Shindig does not properly support
the FEED content type as defined by the gadgets spec for
gadgets.io.MakeRequest
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598212#action_12598212 ]
Kevin Brown commented on SHINDIG-60:
------------------------------------
Sorry for the late feedback. There are a couple of minor outstanding issues:
- Comments for parseFeedAsJson should just reference the gadget spec. The igoogle gadget docs are not canonical, and the opensocial spec may differ. The ig docs will be eliminated at some point in the future (once igoogle has fully migrated to the new code)
- Lots of magic numbers in parseFeedasJson. These should be configurable, or at least constants.
- The feed handling stuff itself should probably be extracted to a separate class to avoid cluttering ProxyHandler too much.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, fix-SHINDIG-60-bug_rome2.patch, fix-SHINDIG-60-bug_rome3.patch, fix-SHINDIG-60_legacy.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated SHINDIG-60:
---------------------------------
Attachment: (was: fix-SHINDIG-60-bug_rome.patch)
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated SHINDIG-60:
---------------------------------
Attachment: fix-SHINDIG-60_legacy.patch
Additional patch for backwards-compatible handling in _IG_FetchFeedAsJSON().
The Google Gadgets specification differs from Shindig's makeRequest() handling in the JSON response object expected by callbacks:
http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
So, when handling ContentType.FEED requests through _IG_FetchFeedAsJSON(), special case the object being pass to the user callback:
In the case of errors, push the response.errors message into response.data.ErrorMsg.
Invoke the callback with only the response.data object, since it expects the feed object directly.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, fix-SHINDIG-60_legacy.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-60) Shindig does not properly support
the FEED content type as defined by the gadgets spec for
gadgets.io.MakeRequest
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594348#action_12594348 ]
Kevin Brown commented on SHINDIG-60:
------------------------------------
Errors to makeRequest calls should always propagate down through the "errors" member of the response object. The expected response form for FEED requests would be:
{
data: (json encoded data, ideally already returned as JSON so as to avoid a redundant parse)
rc: (http status code)
errors: (any errors that occured while processing, in the form of an array of strings)
}
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-60) Shindig does not properly support
the FEED content type as defined by the gadgets spec for
gadgets.io.MakeRequest
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594385#action_12594385 ]
Kevin Brown commented on SHINDIG-60:
------------------------------------
You've also got some brace alignment issues. Specifically, you should be using this:
} else {
instead of this:
}
else {
Not mentioned specifically in our style guide, but inherited from the sun style guide at http://java.sun.com/docs/codeconv/html/CodeConventions.doc6.html#449
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-60) Shindig does not properly support
the FEED content type as defined by the gadgets spec for
gadgets.io.MakeRequest
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595807#action_12595807 ]
Kevin Brown commented on SHINDIG-60:
------------------------------------
Could you add unit tests for the new functionality? At minimum, a new test for ProxyHandler when ContentType == FEED would be appropriate.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, fix-SHINDIG-60-bug_rome2.patch, fix-SHINDIG-60_legacy.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-60) Shindig does not properly support
the FEED content type as defined by the gadgets spec for
gadgets.io.MakeRequest
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595823#action_12595823 ]
Gary Helmling commented on SHINDIG-60:
--------------------------------------
Sure, I'll add in tests covering the Java changes and repost the patch later today.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, fix-SHINDIG-60-bug_rome2.patch, fix-SHINDIG-60_legacy.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated SHINDIG-60:
---------------------------------
Attachment: (was: fix-SHINDIG-60-bug_rome.patch)
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-60) Shindig does not properly support
the FEED content type as defined by the gadgets spec for
gadgets.io.MakeRequest
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594350#action_12594350 ]
Kevin Brown commented on SHINDIG-60:
------------------------------------
Also -- Gary, your patch is great, but the style doesn't match the rest of Shindig. When you can't determine what's appropriate, consult the shindig style guide at http://cwiki.apache.org/confluence/display/SHINDIGxSITE/Java+Style
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown closed SHINDIG-60.
------------------------------
Resolution: Fixed
Applied and done.
Thanks for the patches!
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (Java)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, fix-SHINDIG-60-bug_rome2.patch, fix-SHINDIG-60-bug_rome3.patch, fix-SHINDIG-60_legacy.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated SHINDIG-60:
---------------------------------
Attachment: fix-SHINDIG-60-bug_rome2.patch
Updated patch with Java implementation of ContentType.FEED handling in ProxyHandler, using the ROME library.
This version updates the patch against the latest trunk, fixes a couple trailing space issues, and resolves previously commented code style issues.
This replaces the "fix-SHINDIG-60-bug_rome.patch" file.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, fix-SHINDIG-60-bug_rome2.patch, fix-SHINDIG-60_legacy.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated SHINDIG-60:
---------------------------------
Attachment: fix-SHINDIG-60-bug_rome.patch
Since Eddie is licensed under the GPL (which wouldn't seem to allow use?), I've attached an alternate patch implemented using the ROME library (https://rome.dev.java.net/). ROME is licensed under the Apache License, ver. 2.
This patch takes the same approach as the previous implementation, adding a dependency on ROME in the pom.xml, and returning the JSON object format specified in the Google Gadgets spec (http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON) for the feed content.
One particular question I had was whether the "ErrorMsg" JSON property should be used to communicate errors (as the gadgets spec indicates), or a GadgetException should be thrown to be consistent with other Shindig handling.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated SHINDIG-60:
---------------------------------
Attachment: fix-SHINDIG-60-bug_rome.patch
Updated ROME (http://rome.dev.java.net) implementation of ContentType.FEED proxy handling.
Fixed some remaining code style issues with brace alignment.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown updated SHINDIG-60:
-------------------------------
Component/s: Common Components (PHP)
Common Components (Java)
Adding gadget rendering server components since this will most likely require server side implementation.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown updated SHINDIG-60:
-------------------------------
Component/s: (was: Common Components (PHP))
(was: Common Components (Java))
Gadget Rendering Server (PHP)
Gadget Rendering Server (Java)
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated SHINDIG-60:
---------------------------------
Attachment: fix-SHINDIG-60-bug_rome.patch
Updated patch for ContentType.FEED parsing using ROME library.
Cleaned up excessive line lengths, exception handling, and a few stray tabs that had slipped in to the last patch. Please let me know if there are any other style issues.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-60) Shindig does not properly support
the FEED content type as defined by the gadgets spec for
gadgets.io.MakeRequest
Posted by "Dan Lester (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594358#action_12594358 ]
Dan Lester commented on SHINDIG-60:
-----------------------------------
Gary, thanks so much for consolidating my work so far - I'll take a look shortly.
Kevin (and Gary), I imagined that ErrorMsg was supposed to convey only feed problems, not processing errors. If the proxy component functions perfectly, but there is a problem with the feed RSS, perhaps that should be returned as a 'success' to all Shindig components, but the JSON object that ends up with the gadget contains an ErrorMsg item indicating the feed problem.
Let's say the proxy component blows up for some internal error, then of course that should come back in the normal Shindig way.
I haven't studied the relevant specs in detail at this stage, and I'm not trying to start an argument! Happy to believe your interpretation, but I just wanted to prompt you to consider this possible distinction. Just because the member is called "Error" doesn't mean it's really an "error" in the Shindig sense...
As I see it, Kevin's interpretation provides for better consistency with the other uses of makeRequest, although fails to suppose backward capability for Gadgets - although that could still be built into the Javascript when _IG_FetchFeedAsJson is used.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-60) Shindig does not properly support
the FEED content type as defined by the gadgets spec for
gadgets.io.MakeRequest
Posted by "Milinda Lakmal Pathirage (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591941#action_12591941 ]
Milinda Lakmal Pathirage commented on SHINDIG-60:
-------------------------------------------------
Eddie is licensed under GPL. Can Apache project use that. It may raise license problem in the future.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot updated SHINDIG-60:
--------------------------------
Component/s: (was: Features (Javascript))
(was: Gadget Rendering Server (PHP))
Changed the components, javascript and php already support this.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (Java)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, fix-SHINDIG-60-bug_rome2.patch, fix-SHINDIG-60-bug_rome3.patch, fix-SHINDIG-60_legacy.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-60) Shindig does not properly support
the FEED content type as defined by the gadgets spec for
gadgets.io.MakeRequest
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594383#action_12594383 ]
Gary Helmling commented on SHINDIG-60:
--------------------------------------
Kevin, I just posted an updated patch to clean up the style issues, please let me know if you see any other problems.
Dan, the updated patch does away with the "ErrorMsg" property in favor on consistency with the other usage of makeRequest. It looks like it would be possible to special case the _IG_FetchFeedAsJson handling in core/legacy.js, and since it's for backwards compatibility with existing Gadgets, I agree that might be the best place to handle it. I'm no javascript whiz, but I'll take a crack at it and post it separately.
If I left out any other handling from your patch, please let me know.
Gary
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Dan Lester (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Lester updated SHINDIG-60:
------------------------------
Attachment: io.js.patch
ProxyHandler.java.patch
Here are my changes to ProxyHandler.java in java\gadgets\src\main\java\org\apache\shindig\gadgets\http
and features/core.io/io.js
to enable FEED support.
Added to pom.xml Maven build file:
<dependency>
<groupId>eddie</groupId>
<artifactId>eddie</artifactId>
<version>0.2</version>
</dependency>
eddie-0.2.jar was added to the local Maven repository.
The other jars (internal dependencies of eddie) were just put in libs dir of the webserver.
eddie-0.2.jar
-------------
Main RSS-Parsing library
http://www.davidpashley.com/projects/eddie.html
xercesImpl.jar
--------------
Xerces XML-parsing dependency
http://xerces.apache.org/xerces2-j/
log4j-1.2.15.jar
----------------
Logging module dependency
http://logging.apache.org/log4j/docs/index.html
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown updated SHINDIG-60:
-------------------------------
Assignee: (was: Kevin Brown)
Unassigning this issue for now. If anyone has the time and inclination to work on this, please feel free to do say so and I'll assign to you. Support for both RSS and Atom here would be be ideal.
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features
> Reporter: Cassie Doll
> Priority: Critical
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-60) Shindig does not properly support the
FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated SHINDIG-60:
---------------------------------
Attachment: fix-SHINDIG-60-bug_rome3.patch
Updated implementation of ContentType.FEED handling in ProxyHandler class, using the ROME feed parsing library.
This patch replaces all my previous attachments (fix-SHINDIG-60-bug_rome.patch, fix-SHINDIG-60-bug_rome2.patch, fix-SHINDIG-60_legacy.patch).
Changes since previous version:
- added unit tests for RSS and Atom feed parsing to ProxyHandlerTest
- tweaked "author" setting to fall back to first entry author if no feed-level author
- tweaked date resolution for better Atom support
Total files changed are:
ProxyHandler:
- added parsing of RSS and Atom remote content responses based on ROME (http://rome.dev.java.net) library
ProxyHandlerTest:
- added unit test with sample RSS feed
- added unit test with sample Atom feed
java/gadgets/pom.xml:
- add ROME library as a dependency
features/core/legacy.js:
- wrap callback in _IG_FetchFeedAsJSON to pass back error message and feed object as expected in Google Gadget docs
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, fix-SHINDIG-60-bug_rome2.patch, fix-SHINDIG-60-bug_rome3.patch, fix-SHINDIG-60_legacy.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-60) Shindig does not properly support
the FEED content type as defined by the gadgets spec for
gadgets.io.MakeRequest
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595810#action_12595810 ]
Chris Chabot commented on SHINDIG-60:
-------------------------------------
On the PHP side of things we don't really have unit tests yet (it's on the todo list) however we do have 2 practical tests of rss and atom feeds:
http://shindig.chabotc.com/gadgets/ifr?url=http://shindig.chabotc.com/gadgets/files/samplecontainer/examples/feed_atom.xml
http://shindig.chabotc.com/gadgets/ifr?url=http://shindig.chabotc.com/gadgets/files/samplecontainer/examples/feed_rss.xml
if you want i can add those 2 basic tests to svn (might even add a bit of layout to them then), could come in useful for you too?
> Shindig does not properly support the FEED content type as defined by the gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, fix-SHINDIG-60-bug_rome2.patch, fix-SHINDIG-60_legacy.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json in the same way that the JSON contentType does. It should instead return a structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.